Merged
Conversation
If originalLang-ro is not present in altTitles, will assume "en" title is actually originalLang-ro.
fatotak
changed the title
fatotak
changed the title
Now does not assume title will be tagged as "en", but looks for a dupe of whatever the title lang is in altTitles. If both of the below conditions holds true, then title is treated as romaji of the original language: 1. there is a dupe language in altTitle 2. original language romaji is missing from altTitle
Author
|
Should theoretically fix this issue (can't test because I don't know how to build
It will id |
…ed native entry to title list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to address: #169
Currently, title field is ignored because it's language tag is often wrong.
To address this, this PR adds the following logic:
If
"${originalLang}-ro"is not present inaltTitles, andtitleLanguageis duplicated inaltTitles, will assume title is actually"${originalLang}-ro"and nottitleLanguage.Restores
titleas one of the series title candidates, but changes it's language flag based on what's available inaltTitlesas well as the value oforiginalLang.