Fix casts on addLabelsToIssue#152
Merged
kevmoo merged 3 commits intoSpinlockLabs:masterfrom Aug 22, 2019
Merged
Conversation
Collaborator
|
@dnfield – looks like you need to fix your formatting! |
Contributor
Author
|
Whups. I leave my default at a higher value than 80. Updated. Thanks! |
kevmoo
approved these changes
Jul 29, 2019
Collaborator
|
@dnfield – we don't have tests here. Have you verified this change? |
Contributor
Author
|
Yes - I'd be happy to add a test, but wasn't sure where the appropriate place would be. |
Collaborator
Tests aren't run in CI anyway. Just wanted to check that YOU have verified this fixes things. |
Contributor
This was referenced Sep 12, 2019
kealjones-wk
added a commit
to kealjones-wk/github.dart
that referenced
this pull request
Oct 2, 2019
* master: bump version, update changelog, longer description for points ok, dartfmt cmd line different than in VS Code. weird. formatted w/ 2.5.0 add null aware to prevent errors Adding draft property to PR model. Use github.request directly, just like other put requests Add putJSON fn to GitHub class and use it on updateFile call update changelog for 5.1.0 update pubspec to 5.1.0 Add contents_url to PullRequestFile dartfmt Bump json_annotation dependency (SpinlockLabs#157) Fix casts on addLabelsToIssue (SpinlockLabs#152) fix listFiles (SpinlockLabs#151) Add labels to PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crashes at runtime right now - I think this kind of cast was valid at some point before Dart 2.0 but isn't anymore.