Added prompt message + preference for Auto-finish#111
Merged
Stypox merged 2 commits intoStypox:stt-servicefrom Dec 20, 2022
Merged
Added prompt message + preference for Auto-finish#111Stypox merged 2 commits intoStypox:stt-servicefrom
Stypox merged 2 commits intoStypox:stt-servicefrom
Conversation
Contributor
nebkrid
commented
Dec 13, 2022
nebkrid
commented
- prompt message shows up as hint (if none is provided, default is still "Say something...")
- Auto finish preference setting added: Reason: Vosk is good, but at least in German it is not perfect. Therefore it is easier (and faster: avoid waiting for loading vosk model again) if user gets the possibility to confirm or speak anew before reporting the result back to requesting app.
- added the TODO from Implementing Speech-To-Text Service for other Apps #100 for optional (and seldom used, if ever) extras like EXTRA_BIASING_STRINGS, EXTRA_LANGUAGE for future reference and remind, which extras may be helpful for vosk recognition to improve the results
Owner
|
Yes, thanks, this is the correct way to do a PR to a PR ;-). I think the pieces you added make sense. I will do some minor refinements and then merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.