Add initial version of navigation skill#113
Conversation
There was a problem hiding this comment.
Thank you! Code is almost fine, just a few things to fix here and there. I tested and it already seems to work pretty well.
In the future we could also add things like "navigate from A to B". Also, saying "where is A" should just search for "A" in the navigation app, while "navigate to A" should start a journey from the user's current position to A in the navigation app. I don't know if this is doable with Android geo intents, and feel free not to implement these things already in this PR.
app/src/main/java/org/dicio/dicio_android/skills/navigate/NavigateInfo.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/dicio/dicio_android/skills/navigate/NavigateProcessor.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/dicio/dicio_android/skills/navigate/NavigateProcessor.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/dicio/dicio_android/skills/navigate/NavigateProcessor.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/dicio/dicio_android/skills/navigate/NavigateOutput.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/dicio/dicio_android/skills/navigate/NavigateOutput.java
Outdated
Show resolved
Hide resolved
Stypox
force-pushed
the
navigation-skill
branch
2 times, most recently
from
2058ba9 to
69b5324
Compare
Co-authored-by: primesun <[email protected]>
Co-authored-by: primesun <[email protected]>
Co-authored-by: primesun <[email protected]>
Co-authored-by: primesun <[email protected]>
Co-authored-by: primesun <[email protected]>
…is was an incomplete solution, and was causing extra undesired space removal. Co-authored-by: primesun <[email protected]>
implement next skills
Stypox
force-pushed
the
navigation-skill
branch
from
66dacf2 to
551cfa5
Compare
There was a problem hiding this comment.
I rebased and now all of your commits appear as though they were mine. But your name+email correctly appears in the commit metadata, and I also added "Co-authored-by: primesun <[email protected]>" to commit messages but that didn't solve the issue either...
Anyway, I pushed a few commits to refine some things. "Disabling" fractions in the number parser can be done with .preferOrdinal(true). I also used String instead of NavigationOutput.Data for simplicity. Finally, I made it so that output is requested again to the user in case the place he mentioned could not be understood the first time.
Thank you for this nice skill and for the research about navigation apps!
No problem, this is one reason why I never use git rebase ;) |
2 participants
See #98