Skip to content

Add Ukrainian localization#222

Merged
Stypox merged 19 commits intoStypox:masterfrom
balaraz:master
Jul 28, 2024
Merged

Add Ukrainian localization#222
Stypox merged 19 commits intoStypox:masterfrom
balaraz:master

Conversation

@balaraz
Copy link
Contributor

@balaraz balaraz commented Jul 20, 2024

Added Ukrainian translation for meta data and skills.

Copy link
Owner

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I pushed a few small fixes, and added the language to the selector in the app settings.
Could you update some of the sentences on weblate, so that the examples are relevant to people who speak Ukrainian? E.g. using "Kiev" as the city for navigation, and using a famous Ukrainian song for lyrics?

Here is an APK that you may want to test to see which sentences Dicio understands correctly, and which ones it does not.

Note that the skills that require number or duration parsing are not available (because dicio-numbers is not translated)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"В котрій пісні співають "we will we will rock you"?" from weblate isn't interpreted correctly by these sentences. Could you add another reference sentence, or change the example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the recognition of this sentence.

@balaraz
Copy link
Contributor Author

balaraz commented Jul 25, 2024

@Stypox

Here is an APK that you may want to test to see which sentences Dicio understands correctly, and which ones it does not.

Where can I download the APK file for testing?

@Stypox
Copy link
Owner

Stypox commented Jul 25, 2024

Ooops I forgot to add the link: https://github.com/Stypox/testing-apks/releases/download/2/app-debug.apk

@balaraz
Copy link
Contributor Author

balaraz commented Jul 27, 2024

@Stypox

  • Well, in general, everything works, but unfortunately, the numbers cannot be translated.
  • The Vosk model doesn't always recognize everything correctly, but this is a problem that hasn't been finalized yet.
  • For some reason, it cannot find the weather for any of the Ukrainian cities even when the speech recognition is correct. It is very difficult to say the name in English because Vosk recognizes it as Ukrainian.

Copy link
Owner

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Well, in general, everything works, but unfortunately, the numbers cannot be translated.

Yes, because https://github.com/Stypox/dicio-numbers is only translated in English and Italian at the moment (but it takes a lot of time to translate it properly)

It is very difficult to say the name in English because Vosk recognizes it as Ukrainian.

That's something broken in non-Latin-script languages that will need to be fixed somehow. Also see #22.

@Stypox Stypox merged commit fa2bc9f into Stypox:master Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants