Skip to content

add german media sentences#309

Merged
Stypox merged 4 commits intoStypox:masterfrom
tiptoptom:master
Jul 3, 2025
Merged

add german media sentences#309
Stypox merged 4 commits intoStypox:masterfrom
tiptoptom:master

Conversation

@tiptoptom
Copy link
Contributor

No description provided.

Copy link
Contributor

@Fadikkop Fadikkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to see this, looks good!
Maybe we could test possible misunderstandings through vosk, but otherwise I'll take it like this.

@Fadikkop
Copy link
Contributor

Fadikkop commented Jun 3, 2025

maybe also "hörbuch,hörspiel,podcast"?

@Inhishonor
Copy link
Contributor

@tiptoptom You may want to add the changes in #326. I added a sentence for the lyrics skill.

Copy link
Owner

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is approved from my side, but I'll wait for @Inhishonor to approve too before mergin, since I don't know if their last comment was for requesting changes

@tiptoptom
Copy link
Contributor Author

@tiptoptom You may want to add the changes in #326. I added a sentence for the lyrics skill.

Maybe, but this is about a different skill.

@Stypox
Copy link
Owner

Stypox commented Jul 3, 2025

Oh ok, then in case you can open another PR

@Stypox Stypox merged commit 4df0f41 into Stypox:master Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants