Merged
Conversation
Stypox
requested changes
Sep 23, 2025
Owner
There was a problem hiding this comment.
Thanks for the well done translation! I reviewed the changes using a translator and they all seem pretty reasonable. I made some tiny changes here and there, see the comments in the review, and let me know if I made something wrong. The unresolved comments are those on which I am not completely sure. Thanks again!
app/src/main/sentences/nl/media.yml
Outdated
Comment on lines
+8
to
+9
| - pause|halt|stop|hold (the? song|media|track|music|audio|video|movie|stream|film)? | ||
| - put the? song|media|track|music|audio|video|movie|stream|film on hold |
Owner
There was a problem hiding this comment.
Probably leftover:
Suggested change
| - pause|halt|stop|hold (the? song|media|track|music|audio|video|movie|stream|film)? | |
| - put the? song|media|track|music|audio|video|movie|stream|film on hold |
Comment on lines
+1
to
+3
| dial: | ||
| - bel naar? .who. op? | ||
| - .who. bellen |
Owner
There was a problem hiding this comment.
Are there no other ways to say "Call .who."?
app/src/main/sentences/nl/timer.yml
Outdated
| cancel: | ||
| - stop|"beëindig"|eindig|cancel|annuleer (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) | ||
| - zet (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) af|stil|uit? | ||
| - silence|(shut|turn off)|quiet|mute the? (.name.? time<r|rs?>|bell|alert|sound|ringtone)|(time<r|rs?>|bell|alert|sound|ringtone called|named|(with the name) .name.) |
Owner
There was a problem hiding this comment.
(this also likely remained here by accident)
app/src/main/sentences/nl/timer.yml
Outdated
Comment on lines
+1
to
+13
| set: | ||
| - timer|alarm (voor|over)? .duration. | ||
| - herinner me over .duration. | ||
| - zet|maak|start|begin een? timer|alarm (voor|van|over)? .duration. (genaamd|(de naam)|onder .name.)? | ||
|
|
||
| cancel: | ||
| - stop|"beëindig"|eindig|cancel|annuleer (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) | ||
| - zet (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) af|stil|uit? | ||
| - silence|(shut|turn off)|quiet|mute the? (.name.? time<r|rs?>|bell|alert|sound|ringtone)|(time<r|rs?>|bell|alert|sound|ringtone called|named|(with the name) .name.) | ||
|
|
||
| query: | ||
| - (hoe lang)|(hoeveel tijd|seconden|minuten|uren) (zijn er)? nog voor|op (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) (afgaat|afloopt)? | ||
| - wanneer loopt (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) af |
Owner
There was a problem hiding this comment.
As far as I understand "alarm" in Dutch means "alarm" in English (i.e. the thing that wakes you up in the morning). But this skill sets a timer, not an alarm, so I removed the word "alarm" from these sentences. Let me know if the meaning of "alarm" is actually different.
Suggested change
| set: | |
| - timer|alarm (voor|over)? .duration. | |
| - herinner me over .duration. | |
| - zet|maak|start|begin een? timer|alarm (voor|van|over)? .duration. (genaamd|(de naam)|onder .name.)? | |
| cancel: | |
| - stop|"beëindig"|eindig|cancel|annuleer (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) | |
| - zet (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) af|stil|uit? | |
| - silence|(shut|turn off)|quiet|mute the? (.name.? time<r|rs?>|bell|alert|sound|ringtone)|(time<r|rs?>|bell|alert|sound|ringtone called|named|(with the name) .name.) | |
| query: | |
| - (hoe lang)|(hoeveel tijd|seconden|minuten|uren) (zijn er)? nog voor|op (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) (afgaat|afloopt)? | |
| - wanneer loopt (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) af | |
| set: | |
| - timer (voor|over)? .duration. | |
| - herinner me over .duration. | |
| - zet|maak|start|begin een? timer (voor|van|over)? .duration. (genaamd|(de naam)|onder .name.)? | |
| cancel: | |
| - stop|"beëindig"|eindig|cancel|annuleer (de|het)? (.name.? timer)|(timer genaamd|(met|onder de naam) .name.) | |
| - zet (de|het)? (.name.? timer)|(timer genaamd|(met|onder de naam) .name.) af|stil|uit? | |
| query: | |
| - (hoe lang)|(hoeveel tijd|seconden|minuten|uren) (zijn er)? nog voor|op (de|het)? (.name.? timer)|(timer genaamd|(met|onder de naam) .name.) (afgaat|afloopt)? | |
| - wanneer loopt (de|het)? (.name.? timer)|(timer genaamd|(met|onder de naam) .name.) af |
Stypox
requested changes
Sep 23, 2025
Stypox
approved these changes
Sep 23, 2025
Owner
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
I'm merging for now, but feel free to reply to my feedback and submit more improvements! You can also test this APK, which includes your changes: https://github.com/Stypox/testing-apks/releases/download/24/app-debug.apk .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.