Translate util_yes_no, timer and telephone to French by MXC48-zz · Pull Request #71 · Stypox/dicio-android

MXC48-zz · 2022-04-18T14:07:24Z

Check if it works before adding

Stypox · 2022-04-28T14:09:45Z

This file should not be added into application/src/principal/phrases/fr/ but rather in app/src/main/sentences/fr/ where other French files are. Paths should not be translated ;-)
Also, I think it is ok for now to create a single PR that adds multiple files, otherwise there would be too many PRs.

Stypox

@MXC48 I closed your two other pull requests, moved all changes here and moved the three files in the correct directory.

I reviewed the files, with the suggested changes everything builds fine. Please note that I do not know French, so if some of my suggestions do not make sense, be sure to tell me ;-)
A few notes:

When writing or-groups, the ? should only be put at the end of the group. So if you want something that matches both a, b or nothing, you should write a|b?. And if you want something that matches either le or nothing you should write only le?, there is no need for le?|le.
Remember to close variations groups, i.e. those pieces of words inside <>
- are not allowed as pieces of words, since they are just considered as yet another word separator by Dicio android. Just replace them with a space, which is the way to separate words in dslf files.
If you want diacritics to be matched precisely, you should write e.g. "à" instead of just à, since " " means diacritics sensitive. But most of the times it is better to not specify diacritics at all, since in general we want Dicio to match words even if their diacritics are different (since the TTS might have messed up diacritics, and also because in most cases diacritics are not needed to identify a word)

Stypox · 2022-04-28T14:17:35Z

app/src/main/sentences/fr/telephone.dslf

@@ -0,0 +1,4 @@
+telephone: high
+(r?appel<er?)|(sonne<r)|(téléphone<r|z?>(à?))|(compose<r|z?>)|(contacte<r|z?>)|(le? numéro de) .who.;


Stypox · 2022-04-28T14:17:52Z

app/src/main/sentences/fr/telephone.dslf

@@ -0,0 +1,4 @@
+telephone: high
+(r?appel<er?)|(sonne<r)|(téléphone<r|z?>(à?))|(compose<r|z?>)|(contacte<r|z?>)|(le? numéro de) .who.;
+je veux (appeler) (contacter) .who.;


Suggested change

je veux (appeler) (contacter) .who.;

je veux appeler|contacter .who.;

app/src/main/sentences/fr/telephone.dslf

app/src/main/sentences/fr/timer.dslf

Stypox · 2022-04-28T14:19:04Z

app/src/main/sentences/fr/timer.dslf

+[set] (mettre un?)|configure|démarre|créer un? (.duration.? timer)|(timer pour|de .duration. (appelé|nommé|surnommé|(avec le nom) .name.)?);
+[set] ajoute un timer (de|qui dure) .duration.;
+[cancel] annule|arrête le?|stop (.name.? timer<s?>)|(timer<s?> appelé|nommé|surnommé|(avec le nom) .name.);
+[query] combien de temps (est laissé? sur le?|reste-t-il sur le?) (.name.? timer<s?>)|(timer<s?> appelé|nommé|surnommé|(avec le nom) .name.);


Stypox · 2022-04-28T14:19:16Z

app/src/main/sentences/fr/timer.dslf

+[set] ajoute un timer (de|qui dure) .duration.;
+[cancel] annule|arrête le?|stop (.name.? timer<s?>)|(timer<s?> appelé|nommé|surnommé|(avec le nom) .name.);
+[query] combien de temps (est laissé? sur le?|reste-t-il sur le?) (.name.? timer<s?>)|(timer<s?> appelé|nommé|surnommé|(avec le nom) .name.);
+[query] quand est-ce que le?|le (.name.? timer<s?>)|(timer<s?> appelé|nommé|surnommé|(avec le nom) .name.) (va)? expire<r;


app/src/main/sentences/fr/util_yes_no.dslf

MXC48-zz · 2022-05-01T09:09:27Z

@ MXC48 J'ai fermé vos deux autres demandes de tirage, déplacé toutes les modifications ici et déplacé les trois fichiers dans le répertoire correct.

J'ai examiné les fichiers, avec les modifications suggérées, tout se passe bien. Veuillez noter que je ne connais pas le français, donc si certaines de mes suggestions n'ont pas de sens, assurez-vous de me le dire ;-)Quelques notes:

Lors de l'écriture ou des groupes, le ? should only be put at the end of the group. So if you want something that matches both a, b or nothing, you should write a|b?. And if you want something that matches either le or nothing you should write only le?, there is no need for le?|le.

N'oubliez pas de fermer les groupes de variantes, c'est-à-dire. ces mots à l'intérieur <>

- are not allowed as pieces of words, since they are just considered as yet another word separator by Dicio android. Just replace them with a space, which is the way to separate words in dslf files.

Si vous voulez que les signes diacritiques soient appariés avec précision, vous devez écrire par exemple. "à" instead of just à, since " " means sensible aux signes diacritiques. Mais la plupart du temps, il est préférable de ne pas spécifier du tout les signes diacritiques. car en général, nous voulons que Dicio corresponde aux mots même si leurs signes diacritiques sont différents ,puisque le TTS aurait pu gâcher les signes diacritiques( et aussi parce que dans la plupart des cas, les signes diacritiques ne sont pas nécessaires pour identifier un mot,

Your modifications are consistent in French, there is no problem on it.
I tried to participate as I could in this project, because not knowing how to program I had to deduce the syntax of the other files in French and other languages. I will keep your advice for the next files that will come :)

BrightDV

Hello,
I have made a review for the French part using Stypox's suggestions, I hope that there isn't any mistakes.
Everything else looks good to me!

app/src/main/sentences/fr/telephone.dslf

app/src/main/sentences/fr/timer.dslf

Stypox · 2022-05-01T13:21:52Z

I tried to participate as I could in this project, because not knowing how to program I had to deduce the syntax of the other files in French and other languages. I will keep your advice for the next files that will come :)

You can find out about the syntax here: https://github.com/Stypox/dicio-sentences-compiler#dicio-sentences-language

Check if it works before adding

improvement

Co-authored-by: BrightDV <[email protected]>

Stypox

Thanks @MXC48 and @BrightDV! Note that the timer won't work yet because it depends on the French tranlsation of the number parsing&formatting library: Stypox/dicio-numbers#2

Stypox requested changes Apr 28, 2022

View reviewed changes

Stypox changed the title ~~Create util_yes_no.dslf~~ Translate util_yes_no, timer and telephone to French Apr 28, 2022

Stypox mentioned this pull request Apr 28, 2022

keyword improvement #75

Closed

BrightDV reviewed May 1, 2022

View reviewed changes

MXC48-zz and others added 6 commits December 20, 2022 16:20

Create util_yes_no.dslf

0f9767c

Check if it works before adding

Update util_yes_no.dslf

2efd83e

improvement

Create timer.dslf

48705f8

Create telephone.dslf

9f4b520

Move French dslf files to correct folder

d76f130

Apply suggestions from code review

7c63cc6

Co-authored-by: BrightDV <[email protected]>

Stypox force-pushed the patch-2 branch from 9a04c61 to 7c63cc6 Compare December 20, 2022 15:22

Stypox approved these changes Dec 20, 2022

View reviewed changes

Stypox merged commit c0fe62b into Stypox:master Dec 20, 2022

		@@ -0,0 +1,4 @@
		telephone: high
		(r?appel<er?)\|(sonne<r)\|(téléphone<r\|z?>(à?))\|(compose<r\|z?>)\|(contacte<r\|z?>)\|(le? numéro de) .who.;

	(r?appel<er?)\|(sonne<r)\|(téléphone<r\|z?>(à?))\|(compose<r\|z?>)\|(contacte<r\|z?>)\|(le? numéro de) .who.;
	(r? appel<er?>)\|(sonne<r?>)\|(téléphone<r\|z?> (à?))\|(compose<r\|z?>)\|(contacte<r\|z?>)\|(le? numéro de) .who.;

	je veux (appeler) (contacter) .who.;
	je veux appeler\|contacter .who.;

	[query] combien de temps (est laissé? sur le?\|reste-t-il sur le?) (.name.? timer<s?>)\|(timer<s?> appelé\|nommé\|surnommé\|(avec le nom) .name.);
	[query] combien de temps est laissé? (reste t il)? sur le? (.name.? timer<s?>)\|(timer<s?> appelé\|nommé\|surnommé\|(avec le nom) .name.);

	[query] quand est-ce que le?\|le (.name.? timer<s?>)\|(timer<s?> appelé\|nommé\|surnommé\|(avec le nom) .name.) (va)? expire<r;
	[query] quand est ce que le? (.name.? timer<s?>)\|(timer<s?> appelé\|nommé\|surnommé\|(avec le nom) .name.) va? expire<r?>;

Uh oh!

Conversation

MXC48-zz commented Apr 18, 2022

Uh oh!

Stypox commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Stypox left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Stypox Apr 28, 2022

Choose a reason for hiding this comment

Uh oh!

Stypox Apr 28, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Stypox Apr 28, 2022

Choose a reason for hiding this comment

Uh oh!

Stypox Apr 28, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MXC48-zz commented May 1, 2022

Uh oh!

BrightDV left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Stypox commented May 1, 2022

Uh oh!

Stypox left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Stypox commented Apr 28, 2022 •

edited

Loading

Stypox left a comment •

edited

Loading

BrightDV left a comment •

edited

Loading

Stypox left a comment •

edited

Loading