Update README for adding skills to SkillHandler'#90
Merged
Stypox merged 1 commit intoStypox:masterfrom Jul 18, 2022
Merged
Conversation
Stypox
approved these changes
Jul 18, 2022
Owner
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Thanks! Yeah, I forgot this part 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates dicio's README with additional instructions for users attempting to add new skills. Specifically, the updated README now includes the final step that includes updating the SkillHandler to make this skill visible for use at runtime. This PR addresses the (perhaps non-specific) issue referred to in #89. The sufficiency of this documentation update for adding skills was confirmed by successfully compiling dicio-assistant with a new skill (shortly forthcoming) against OpenJDK 14 using the default Gradle 7.4 toolchain as specified in commit 32aeadd, and running on Android 12.