[current_time] Initial commit for skill to say current time#91
Merged
Stypox merged 4 commits intoStypox:masterfrom Jul 26, 2022
Merged
[current_time] Initial commit for skill to say current time#91Stypox merged 4 commits intoStypox:masterfrom
Stypox merged 4 commits intoStypox:masterfrom
Conversation
Stypox
requested changes
Jul 18, 2022
app/src/main/java/org/dicio/dicio_android/skills/current_time/CurrentTimeInfo.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/dicio/dicio_android/skills/current_time/CurrentTimeInfo.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/dicio/dicio_android/skills/current_time/CurrentTimeOutput.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/dicio/dicio_android/skills/current_time/CurrentTimeStringProcessor.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
All changes implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a new feature/skill allowing the user to poll dicio for the current time. This skill is added to the en/default locale but not updated to any others. This skill has been verified working in debug builds using OpenJDK 14/Gradle 7.4 installed on Android 12.
(BTW, thanks for providing this infrastructure. Has been a good way to get into the Android app environment/ecosystem, and dicio is a good asset to the community.)
Edit 7/23: This skill now uses its own material design logo.