This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Fix indentation on code blocks inside discussion elements#114
Merged
mattt merged 1 commit intoSwiftDocOrg:masterfrom May 19, 2020
Merged
Conversation
Using `text-indent` will indent every line after the first, which makes sense for declaration code blocks, but not necessarily for multiline code blocks inside documentation.
89aea05 to
128fd1b
Compare
Contributor
|
Thanks for taking this on, @samsymons! At first glance, this looks right. I'll have a chance to try it out locally in the next day or two. |
mattt
approved these changes
May 19, 2020
mattt
added a commit
that referenced
this pull request
May 19, 2020
Contributor
|
😅 Whoops, I neglected to add a changelog entry for this. Added that with 5dafcb1. Thanks again for your help on this, @samsymons! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes up an issue where code blocks were receiving inconsistent indentation.
The root cause here comes from the discussion in #113, where the
text-indentCSS property was being applied to all code blocks, rather than just those outside of discussion elements.My guess here is that
text-indentshould stay on all code blocks except those with the.discussionclass, where it's not uncommon to have multi-line code blocks, so this PR setstext-indentto 0 and adjusts the padding accordingly to remove thepadding-left.I'm still learning the internals of SwiftDoc and currently dusting off years-old CSS knowledge, so give me a shout if this solution is off base! ❤️
Fixes #113.