This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Ensure that the member type icon is correct#115
Merged
mattt merged 4 commits intoSwiftDocOrg:masterfrom May 19, 2020
Merged
Conversation
This was using the `symbol` property, which will use the type of the member’s related type. Instead, it should use the member being iterated over.
mattt
approved these changes
May 19, 2020
Contributor
mattt
left a comment
There was a problem hiding this comment.
Wow, as simple as that, huh? Thanks for catching this and providing the patch. Glad to see this wasn't a more involved fix.
Contributor
|
Thanks for your help on these visual bugs, @samsymons. I'm in the process of cutting a new release now. Really glad to have these squashed for 1.0.0-beta.3! |
Contributor
Author
|
@mattt No problem! Thank you for the fantastic tool 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the type icon being emitted in certain situations was incorrect.
Admittedly I was slightly dreading tracking this one down, but the fix was fortunately simple: the parent symbol for the member was being used to generate the icon, rather than the member itself.
Here's the generated pages for enums and typealiases after the change (embedded in collapsible sections to keep things tidy):
Enum
Typealias
Fixes #64.