Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

Add option for specifying which access levels are included#219

Merged
mattt merged 12 commits intoSwiftDocOrg:masterfrom
Ehlster:MinimumAccessLevel
Feb 23, 2021
Merged

Add option for specifying which access levels are included#219
mattt merged 12 commits intoSwiftDocOrg:masterfrom
Ehlster:MinimumAccessLevel

Conversation

@Ehlster
Copy link
Member

@Ehlster Ehlster commented Feb 16, 2021

This is another try to close #72 - I really want to document my apps.

This slightly changes the behaviour of the internal data structures which collect information on the symbols (e.g. Interface, Members and Symbol). Now, they contain every symbol, not only the public ones. The decision which symbol to include in the documentation is moved to the generating of the documentation.

…ymbols.

This slightly changes the behaviour of the internal data structures which
collect information on the symbols (e.g. Interface, Members and Symbol). Now,
they contain every symbol, not only the public ones. The decision which symbol
to include in the documentation is moved to the generating of the
documentation.
@mattt
Copy link
Contributor

mattt commented Feb 16, 2021

@Lukas-Stuehrk Thanks so much for working on this. And apologies for not giving swift-doc as much attention as I'd like to lately. Work on the Swift package registry proposal has monopolized my time, but I'm looking forward to focusing back on this project again really soon. I'll start by taking a look at the PR — hopefully sometime this week.

Copy link
Contributor

@mattt mattt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @Lukas-Stuehrk! Just a few, small changes to make on my end. Otherwise, this is ready to go in. Nice work!

mattt added a commit to Ehlster/swift-doc that referenced this pull request Feb 23, 2021
@Ehlster
Copy link
Member Author

Ehlster commented Feb 23, 2021

🙇 It's always a pleasure to contribute to one of your projects, @mattt. I will sign the commits so the pull request is mergeable.

@mattt
Copy link
Contributor

mattt commented Feb 23, 2021

Alright, CI is passing so I'll merge this in now. Thanks again for your great work on this, @Lukas-Stuehrk!

@mattt mattt merged commit da1189a into SwiftDocOrg:master Feb 23, 2021
@Ehlster Ehlster deleted the MinimumAccessLevel branch February 23, 2021 18:25
@ApplebaumIan
Copy link

👏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to generate subcommand for specifying which access levels are included

3 participants