This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Fixing protocol requirements html rendering#76
Merged
mattt merged 3 commits intoSwiftDocOrg:masterfrom Apr 10, 2020
Merged
Conversation
mattt
approved these changes
Apr 10, 2020
mattt
suggested changes
Apr 10, 2020
Contributor
mattt
left a comment
There was a problem hiding this comment.
Oh right, we should update the Changelog, too, so that everyone knows this is fixed in the next release!
Contributor
|
Great work, @victor-pavlychko! Thanks for taking this on.
Yeah, this definitely seems like a useful pattern that we may want to apply more systematically. I'll factor this into my approach for #67. |
Contributor
Author
|
Sure, I added one more entry. I have also checked my previous PR with GraphViz installed and noticed a bug with HTML figure escaping, adding the fix here too, as it's a one-liner. |
mattt
approved these changes
Apr 10, 2020
Contributor
|
Awesome. Thanks again, @victor-pavlychko! Merging this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71
This PR aligns
Requirementswith other similar components:MembersandRelationships. What do you think about extracting shared section logic into a new component or base class?