Conversation
daniel-123
reviewed
Dec 28, 2020
Contributor
daniel-123
left a comment
There was a problem hiding this comment.
I don't see any blocking problems with this PR.
21e03fa to
3b438d4
Compare
3b438d4 to
e4c8d58
Compare
Closed
86b0798 to
eddd453
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, the CI flow that was on Travis CI is migrated to GitHub Actions. Some minor changes to the build chain and/or to the codebase were also applied, which are further detailed platform by platform hereafter.
apt-get updatewas added in the test script.thesnapcraft.yamlrecipe was completely rewritten to usecore18as base snap, Python 3.6, and PySide2. After this change, we will not have a released platform based on Qt 4 anymore.this could also allow us to increase the minimum Python version for Syncplay to 3.6. On paper, we still support>=3.4, hence I reverted in this PR the f-string accidentally introduced in Console improvements #327. However,python_mpv_jsonipcalready requires 3.6.A few general comments about the two CI platforms:
.travis.ymlfile was deleted. The helper foldertravisis now namedci. The build status badge in README now points to GitHub Actions.