Use PySide6 for non-windows + python >= 3.12#645
Conversation
|
Looks like Windows build fails, should I do: diff --git a/requirements_gui.txt b/requirements_gui.txt
index ba12db7..208cb3b 100644
--- a/requirements_gui.txt
+++ b/requirements_gui.txt
@@ -1,3 +1,3 @@
-pyside2>=5.11.0; sys_platform != 'darwin'
-pyside6; sys_platform == 'darwin'
+pyside2>=5.11.0; sys_platform == 'win32'
+pyside6; sys_platform != 'win32'
requests>=2.20.0; sys_platform == 'darwin'instead, or attempt to migrate win32 to PySide6? |
|
In terms of which PySide to use, the constraints are as follows:
Taking this into account, for maximum compatibility the GUI requirements should be PySide6 for darwin (macOS) and for non-Darwin:
We might move Windows to PySide6 and 64-bit in the future, but probably best not to make that switch without extensive testing. |
Does this look fine? |
From a visual inspection it looks good to me, although I am no requirements.txt expert. I guess the next thing to do is to make the commit on your branch for the build to update and then we test if it works in practice. |
PySide2 is dead and won't support Python 3.12 or newer.
Ok, I force pushed my branch. Also I tried |
|
Runs fine for me on Windows 10. |
PySide2 is dead and won't support Python 3.12 or newer.