Skip to content

feat: integrate solid v2 query#6938

Merged
birkskyum merged 13 commits intosolid-router-v2-prefrom
integrate-solid-query
Mar 18, 2026
Merged

feat: integrate solid v2 query#6938
birkskyum merged 13 commits intosolid-router-v2-prefrom
integrate-solid-query

Conversation

@brenelz
Copy link
Contributor

@brenelz brenelz commented Mar 16, 2026

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 16, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1535cd20-846b-4d55-9d5e-2e9f7db233a5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch integrate-solid-query
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Mar 16, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 41004f8

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 1m 3s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-18 01:34:48 UTC

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2026 •
edited
Loading

Bundle Size Benchmarks

  • Commit: b065aee927c4
  • Measured at: 2026-03-18T01:34:45.875Z
  • Baseline source: history:6651473d028a
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 87.61 KiB 0 B (0.00%) 276.07 KiB 76.12 KiB ▁▁▁▁▁▁▁████
react-router.full 90.65 KiB 0 B (0.00%) 286.28 KiB 78.68 KiB ▁▁▁▁▁▁▁████
solid-router.minimal 40.19 KiB +3.05 KiB (+8.22%) 117.98 KiB 36.24 KiB ▁▁▁▁▁▁▁▂▂▂▂█
solid-router.full 44.11 KiB +2.75 KiB (+6.66%) 130.17 KiB 39.67 KiB ▁▁▁▁▁▁▁▂▂▂▂█
vue-router.minimal 52.99 KiB 0 B (0.00%) 151.41 KiB 47.65 KiB ▁▁▁▁▁▁▁████
vue-router.full 57.69 KiB 0 B (0.00%) 166.34 KiB 51.60 KiB ▁▁▁▁▁▁▁████
react-start.minimal 101.99 KiB 0 B (0.00%) 324.08 KiB 88.20 KiB ▁▁▁▁▁▁▁████
react-start.full 105.33 KiB 0 B (0.00%) 333.89 KiB 91.02 KiB ▁▁▁▁▁▁▁████
solid-start.minimal 59.88 KiB +8.64 KiB (+16.87%) 182.31 KiB 52.85 KiB ▁▁▁▁▁▁▁▃▃▃▃█
solid-start.full 63.67 KiB +7.14 KiB (+12.64%) 193.49 KiB 56.15 KiB ▁▁▁▁▁▁▁▃▃▃▃█

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 16, 2026 •
edited
Loading

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@6938

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@6938

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@6938

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@6938

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@6938

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@6938

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@6938

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@6938

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@6938

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@6938

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@6938

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@6938

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@6938

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@6938

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@6938

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@6938

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@6938

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@6938

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@6938

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@6938

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@6938

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@6938

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@6938

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@6938

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@6938

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@6938

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@6938

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@6938

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@6938

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@6938

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@6938

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@6938

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@6938

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@6938

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@6938

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@6938

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@6938

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@6938

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@6938

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@6938

commit: 41004f8

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 16, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 6 untouched benchmarks

Comparing integrate-solid-query (41004f8) with solid-router-v2-pre (cde6e61)1

Open in CodSpeed

Footnotes

  1. No successful run was found on solid-router-v2-pre (988e3f7) during the generation of this report, so 0b74c9f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@birkskyum birkskyum changed the title WIP: Integrate solid query WIP: Integrate solid v2 query Mar 16, 2026
@brenelz brenelz requested a review from birkskyum March 17, 2026 01:51
@TanStack TanStack deleted a comment from changeset-bot bot Mar 17, 2026
@birkskyum birkskyum marked this pull request as ready for review March 18, 2026 00:46
@birkskyum birkskyum changed the title WIP: Integrate solid v2 query feat: integrate solid v2 query Mar 18, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2026 •
edited
Loading

Changeset Version Preview

1 package(s) bumped directly, 0 bumped as dependents.

Direct bumps

Package Bump Version
@tanstack/solid-router-ssr-query patch 2.0.0-alpha.2 → 2.0.0-alpha.3

birkskyum
birkskyum reviewed Mar 18, 2026
View reviewed changes
@birkskyum birkskyum merged commit 69da501 into solid-router-v2-pre Mar 18, 2026
16 checks passed
@birkskyum birkskyum deleted the integrate-solid-query branch March 18, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@birkskyum birkskyum birkskyum approved these changes

Assignees

No one assigned

Labels

package: solid-router-ssr-query solid-v2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brenelz @birkskyum