Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
=======================================
Coverage 79.83% 79.83%
=======================================
Files 36 36
Lines 5429 5429
=======================================
Hits 4334 4334
Misses 1095 1095 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@thierry-martinez Just wanted to kindly check in and see if you’ve had a chance to look at the PR. I’d appreciate your feedback whenever you have time |
|
@WingCode thanks for the PR! Just want to check that entire library was scanned for the potential enhancements mentioned in the issued, copied below?
|
|
Optionally I'm very happy if these things are covered in this PR:
|
|
Hi @shinich1 / @EarlMilktea, I've implemented the requested changes. Please let me know if there's anything else you'd like me to update or revise. |
shinich1
left a comment
There was a problem hiding this comment.
LGTM. Thanks a lot! as per cotributing.md, may I kindly ask, if you're happy, to give this repo a star?
actually, CI seems to have failed. Could you check them? I will then approve this.
|
@shinich1 Happy to |
EarlMilktea
left a comment
There was a problem hiding this comment.
Looks good. Thank you very much for your great contribution!
|
@EarlMilktea The CI pipeline errors should be fixed now |
|
@EarlMilktea Thank you very much for neatly organising a commit for me. I have tried to incorporated the commit abc87a7. If any further changes is required, please feel free to go ahead and change it! |
Before submitting, please check the following:
nox)ruffCONTRIBUTING.mdfor more detailsThen, please fill in below:
Context (if applicable):
closes #226
Description of the change:
Related issue: