-
Notifications
You must be signed in to change notification settings - Fork 73
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
Hi, you did a good job on this project, I really like to use it.
I noticed one small thing -- when you run the program with -decompile JADX, you can see the following in the output:
...
[+]Decompling JAR with DEX2JAR
dex2jar /opt/AndroidProjectCreator/target/library/temp/8a9550a5-7498-4d34-a1d8-86375119c668/apktool/classes.dex -> /opt/AndroidProjectCreator/target/library/temp/8a9550a5-7498-4d34-a1d8-86375119c668/output.jar
[+]Decompilation finished
[+]Decompling JAR with JADX
INFO - loading ...
INFO - processing ...
...
But JADX is a DEX -> Java decompiler and it does not need a JAR. In fact, when you give JADX a JAR file, JADX will convert it to DEX first:
$ jadx -d $(pwd) $(pwd)/classes-dex2jar.jar
INFO - loading ...
INFO - converting to dex: classes-dex2jar.jar ...
...AndroidProjectCreator works well even now, going DEX -> JAR -> (DEX) -> Java, and this issue has a low severity. But if it decompiled to Java straight from DEX, it might save some execution time. Also, the results might be a little more accurate, as I can imagine that the DEX -> JAR -> DEX conversion can lead to some kind of loss of information or precision, especially with obfuscated APKs.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request