This repository was archived by the owner on Jun 9, 2023. It is now read-only.
Merged
Conversation
Collaborator
Author
|
I will try to find out how is rate limiting applies to free clients as of now |
Collaborator
Author
|
ping @saket |
|
Switching to free endpoints should be fine. I chose to use their paid APIs because Dank wasn't open sourced back then and I had plans to introduce a paid version. |
Collaborator
Author
|
Upload works ok. I guess PR is ready to merge |
Collaborator
Author
|
@saket I think mashape token can be invalidated after merge. Old clients won't work due to endpoint change anyway |
Tunous
approved these changes
May 8, 2020
Owner
|
Thanks, merged :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like Imgur changed their paid api endpoint (very clever of them) and this caused imgur albums and images to stop loading.
Imgur api docs states this:
So i've just changed endpoint to the free one and it works so far (albums/images). I haven't checked uploading yet but according to docs this should work too. But comment in code says:
- so I don't know if I just should update this to new paid endpoint. If we decide to keep free one, then all rate-limit code probably can be removed.