This repository was archived by the owner on Jun 9, 2023. It is now read-only.
Imgur low quality images for data saving mode#256
Merged
Tunous merged 7 commits intoTunous:masterfrom Jun 17, 2020
Merged
Conversation
Collaborator
Author
Implementing #257 will address this. I will probably work on this myself |
Tunous
suggested changes
Jun 16, 2020
Owner
Tunous
left a comment
There was a problem hiding this comment.
The code looks good. The only concern I have is with unit tests. I can see that a lot of code changed so it would be nice to have new tests written for it just to stay safe in future.
|
|
||
| /** | ||
| * Extracts Imgur preview suffix and file extension | ||
| * Extracts Imgur image id (1) and extension (2) if exists |
Owner
There was a problem hiding this comment.
It would be nice to also add unit tests on these new possibilities.
|
|
||
| HttpUrl imageUrl = HttpUrl.parse(url) | ||
| @SuppressWarnings("ConstantConditions") | ||
| public ImgurLink createImgurLink(String url, @Nullable String title, @Nullable String description, Boolean fallback) { |
Owner
There was a problem hiding this comment.
I don’t know if we have tests like this but it would be nice to have at least one for each handled situation since there are many changes in this function and it is public.
7908359 to
47a48aa
Compare
47a48aa to
36536b9
Compare
Collaborator
Author
|
That should cover all of new logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily for albums since reddit provides its own previews for single images.
This is also fixes bug with gifs failing to load if they're actually a static image. Won't work if invalid url is already in user's persistent cache tough.