Skip to content
This repository was archived by the owner on Jun 9, 2023. It is now read-only.

Limit Glide cache to 200 MB#381

Merged
msfjarvis merged 1 commit intoTunous:masterfrom
msfjarvis:cache-size-limit
Feb 1, 2021
Merged

Limit Glide cache to 200 MB#381
msfjarvis merged 1 commit intoTunous:masterfrom
msfjarvis:cache-size-limit

Conversation

@msfjarvis
Copy link
Collaborator

@msfjarvis msfjarvis commented Jan 27, 2021

Gonna take a while to see if it truly works so letting this be a draft for now

@AbsurdlySuspicious
Copy link
Collaborator

AbsurdlySuspicious commented Feb 1, 2021 

root@localhost /d/d/m/cache# du -hd 1 | sort -h
212K    ./disk_lru_cache
22M     ./WebView
202M    ./image_manager_disk_cache
224M    .
root@localhost /d/d/m/cache# du -hd 1 | sort -h
212K    ./disk_lru_cache
22M     ./WebView
201M    ./image_manager_disk_cache
223M    .

I scrolled the feed and downloaded some pretty large images between these two du invocations so this works good

@AbsurdlySuspicious
Copy link
Collaborator

AbsurdlySuspicious commented Feb 1, 2021

Maybe there's also some sense in making this limit configurable. This is surely matter of another PR though

@msfjarvis
Limit Glide cache to 200 MB
16fa01d 
Fixes Tunous#353

Signed-off-by: Harsh Shandilya <[email protected]>
@msfjarvis msfjarvis marked this pull request as ready for review February 1, 2021 13:15
@msfjarvis msfjarvis enabled auto-merge (squash) February 1, 2021 13:15
@msfjarvis msfjarvis merged commit f9403ad into Tunous:master Feb 1, 2021
@msfjarvis msfjarvis deleted the cache-size-limit branch February 1, 2021 13:19
@msfjarvis msfjarvis added this to the 0.12.3 milestone Feb 1, 2021
@msfjarvis msfjarvis added the code Pull requests that make code only related changes label Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@AbsurdlySuspicious AbsurdlySuspicious AbsurdlySuspicious approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code Pull requests that make code only related changes

Projects

None yet

Milestone

0.12.3

Development

Successfully merging this pull request may close these issues.

2 participants

@msfjarvis @AbsurdlySuspicious