Skip to content
This repository was archived by the owner on Jun 9, 2023. It is now read-only.

MediaDownloadService: Run Glide clear on main thread#57

Merged
Tunous merged 1 commit intoTunous:masterfrom
msfjarvis:msf/fix-redownload-crash
Aug 21, 2019
Merged

MediaDownloadService: Run Glide clear on main thread#57
Tunous merged 1 commit intoTunous:masterfrom
msfjarvis:msf/fix-redownload-crash

Conversation

@msfjarvis
Copy link
Collaborator

Fixes #56

@msfjarvis msfjarvis force-pushed the msf/fix-redownload-crash branch from 9ebc68c to f4680d1 Compare August 20, 2019 22:04
@msfjarvis msfjarvis changed the title MediaDownloadService: Rust Glide clear on main thread MediaDownloadService: Run Glide clear on main thread Aug 20, 2019
@Tunous Tunous added the bug Something isn't working label Aug 21, 2019
@Tunous Tunous added this to the 0.8.0 milestone Aug 21, 2019
@tunous-bot
Copy link

Test version of Dank has been automatically built from this pull request.
Click here to download it.

@Tunous Tunous merged commit ee12762 into Tunous:master Aug 21, 2019
@msfjarvis msfjarvis deleted the msf/fix-redownload-crash branch August 21, 2019 16:50
mvietri pushed a commit to mvietri/Dawn that referenced this pull request Aug 24, 2019
@Tunous
Copy link
Owner

Tunous commented Sep 8, 2019

Unfortunately it looks like this fix is not working properly in all cases. Bugsnag is reporting crashes (#77) that directly point at this change.

Do you have other ideas for a fix?

@msfjarvis
Copy link
Collaborator Author

Unfortunately it looks like this fix is not working properly in all cases. Bugsnag is reporting crashes (#77) that directly point at this change.

Do you have other ideas for a fix?

I'll look into it a bit more

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-downloading the same image causes app crash

3 participants