Avoid constructing a DocumentFragment unnecessarily in DOMParser::parseFromString()#17023
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Aug 24, 2023
Conversation
cdumez
added
the
DOM
Collaborator
|
EWS run on current version of this PR (hash 79f4649) Details
|
…seFromString() https://bugs.webkit.org/show_bug.cgi?id=260665 Reviewed by Yusuke Suzuki. Avoid constructing a DocumentFragment unnecessarily in DOMParser::parseFromString(). Have the HTML fast parser construct the subtree under the <body> element directly instead. * Source/WebCore/dom/DocumentFragment.cpp: (WebCore::DocumentFragment::parseHTML): * Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp: (WebCore::HTMLFastPathParser::HTMLFastPathParser): (WebCore::HTMLFastPathParser::parseCompleteInput): (WebCore::tryFastParsingHTMLFragmentImpl): (WebCore::tryFastParsingHTMLFragment): * Source/WebCore/html/parser/HTMLDocumentParserFastPath.h: * Source/WebCore/xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString): Canonical link: https://commits.webkit.org/267242@main
webkit-commit-queue
force-pushed
the
260665_parseFromString_no_DocumentFragment
branch
from
79f4649 to
903209c
Compare
Collaborator
|
Committed 267242@main (903209c): https://commits.webkit.org/267242@main Reviewed commits have been landed. Closing PR #17023 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
903209c
79f4649
🧪 wpe-wk2🧪 mac-AS-debug-wk2