[CSSTransition] Do not list up all properties for transition: all by Constellation · Pull Request #18054 · WebKit/WebKit

Constellation · 2023-09-21T23:40:30Z

`66eb8a0`

[CSSTransition] Do not list up all properties for transition: all
https://bugs.webkit.org/show_bug.cgi?id=261917
rdar://115861030

Reviewed by Antti Koivisto.

When `transition: all ...` CSS rule is applied, we end up listing all animatable properties.
This is incredibly costly since there are so many CSS properties. And all properties are queried,
checked equality via very slow virtual function. Many hash table lookups etc.
We found that we are using massive amount of time in this transitioning in Speedometer3/NewsSite-Next / NewsSite-Nuxt.

But in almost all cases, almost all properties are not related at all.

In this patch, we do RenderStyle comparison and collect all affected CSS properties candidate which needs to be visited in
updateCSSTransitions. We can conservatively say "this property needs to be visited". But if we know that this
is totally equal, then we can skip that.

We cannot use RenderStyle::diff for this purpose. It is highly tailored to rendering purpose. And a lof of
properties changes are not reported when it is unrelated to layout (but it is necessary for updateCSSTransitions).
Example is `top` / `left`. So instead, we have more tailored path collecting necessary properties in this patch.

With this patch, we always collect all possible affected properties. So we no longer need to list up all animatable properties.
It results in 0.7% progression in Speedometer3.

* Source/WebCore/dom/Element.cpp:
(WebCore::Element::hasAnimations const):
* Source/WebCore/dom/Element.h:
* Source/WebCore/dom/ElementRareData.h:
(WebCore::ElementRareData::hasAnimations const):
* Source/WebCore/style/Styleable.cpp:
(WebCore::Styleable::updateCSSTransitions const):

Canonical link: https://commits.webkit.org/268412@main

a6f45ad

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

cdumez

Not familiar enough with this code to know if this change is OK.

cdumez · 2023-09-21T23:43:59Z

Source/WebCore/dom/Element.cpp

nit: could be a one liner:
return hasRareData() && elementRareData()->hasAnimations()

cdumez · 2023-09-21T23:45:17Z

Source/WebCore/style/Styleable.cpp

{ } shouldn't be needed.

webkit-early-warning-system · 2023-09-21T23:47:26Z

EWS run on previous version of this PR (hash 793a450)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-09-22T07:05:05Z

EWS run on previous version of this PR (hash 0ac729e)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc-arm64	✅ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

Constellation · 2023-09-22T07:26:22Z

Still testing.

webkit-early-warning-system · 2023-09-22T07:37:46Z

EWS run on previous version of this PR (hash c9ad8e4)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	~~🧪 mac-wk2~~	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-09-22T08:35:01Z

EWS run on previous version of this PR (hash ed190dd)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	~~🛠 mac~~	⏳ 🛠 wpe	~~🛠 wincairo~~
✅ 🧪 bindings	~~🛠 ios-sim~~	❌ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	⏳ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	⏳ 🧪 gtk-wk2
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	⏳ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	⏳ 🛠 tv-sim	~~🧪 mac-wk2-stress~~
	❌ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-09-22T08:43:37Z

EWS run on previous version of this PR (hash 6e9008f)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-09-22T10:08:34Z

EWS run on previous version of this PR (hash fc23ce9)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

Constellation · 2023-09-22T10:33:48Z

I should add transition specific property collector like RenderStyle::diff. And also set KeyframeEffect. So then we can filter out affected ones.

webkit-early-warning-system · 2023-09-22T18:27:05Z

EWS run on previous version of this PR (hash c44d5bf)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	⏳ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-09-25T06:15:35Z

EWS run on previous version of this PR (hash 2cc1a97)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	⏳ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-09-25T06:19:31Z

EWS run on previous version of this PR (hash 8298c9b)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	⏳ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-09-25T06:42:43Z

EWS run on previous version of this PR (hash 44e015f)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-09-25T06:42:44Z

EWS run on previous version of this PR (hash 4ac71ae)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 wincairo~~
~~🧪 bindings~~	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🛠 gtk~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	⏳ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
⏳ 🧪 services	✅ 🛠 tv-sim	~~🧪 mac-wk2-stress~~
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-09-25T07:06:36Z

EWS run on previous version of this PR (hash 088b81b)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

anttijk · 2023-09-25T10:28:08Z

Source/WebCore/animation/WebAnimationTypes.h

Does this really need a class (struct?) rather than using CSSPropertiesBitSet = WTF::BitSet<numCSSProperties>?

The reason of this is not adding CSSPropertyNames.h dependency from RenderStyle.h, since numCSSProperties is defined in that header.

numCSSProperties could be generated to a header of its own.

Please at least make this a struct and use struct style member naming (withou m_ prefix).

Thanks, I've changed it to struct for now.

anttijk · 2023-09-25T10:45:10Z

Source/WebCore/rendering/style/RenderStyle.cpp

How does it answer the first question negatively? What happens then?

This really does seem like something that should be autogenerated from CSSProperties.json. It will be difficult to keep it up to date when new properties are added.

Now, this patch covers all the cases, and removed the fast path. So (1) should be removed, it is always handled in this code.

This really does seem like something that should be autogenerated from CSSProperties.json. It will be difficult to keep it up to date when new properties are added.

It is ideal. But right now, we do not have a mechanism to generate data structures, and RenderStyle::diff is also not doing it. So for now, this patch is aligning the approach to RenderStyle::diff. When introducing a mechanism to solve RenderStyle::diff etc. too, this probably can be organized in the same way.

anttijk · 2023-09-25T10:49:05Z

Source/WebCore/rendering/style/RenderStyle.cpp

Affected how? I think this is more like collectChangedProperties or conservativelyCollectChangedProperties

But I suppose this currently limited to animatable properties so conservativelyCollectChangedAnimatableProperties or something.

Sounds good. Changed it to conservativelyCollectChangedAnimatableProperties.

anttijk · 2023-09-25T11:04:35Z

Source/WebCore/rendering/style/RenderStyle.cpp

As far as I can tell any missing property here will just fail to animate?

Yes, for transition all case.

webkit-early-warning-system · 2023-09-25T16:08:48Z

EWS run on previous version of this PR (hash e8ac477)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	⏳ 🧪 gtk-wk2
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	✅ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-09-25T16:38:12Z

EWS run on previous version of this PR (hash 3e52d82)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
~~🧪 bindings~~	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	⏳ 🧪 api-mac	✅ 🛠 gtk
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	⏳ 🧪 gtk-wk2
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	✅ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

anttijk · 2023-09-25T16:39:40Z

Source/WebCore/rendering/style/SVGRenderStyle.cpp

please add a FIXME about autogenerating all this.

webkit-early-warning-system · 2023-09-25T16:40:49Z

EWS run on previous version of this PR (hash d68e508)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
~~🧪 bindings~~	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	⏳ 🧪 api-mac	✅ 🛠 gtk
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	⏳ 🧪 gtk-wk2
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-09-25T16:43:18Z

EWS run on current version of this PR (hash a6f45ad)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=261917 rdar://115861030 Reviewed by Antti Koivisto. When `transition: all ...` CSS rule is applied, we end up listing all animatable properties. This is incredibly costly since there are so many CSS properties. And all properties are queried, checked equality via very slow virtual function. Many hash table lookups etc. We found that we are using massive amount of time in this transitioning in Speedometer3/NewsSite-Next / NewsSite-Nuxt. But in almost all cases, almost all properties are not related at all. In this patch, we do RenderStyle comparison and collect all affected CSS properties candidate which needs to be visited in updateCSSTransitions. We can conservatively say "this property needs to be visited". But if we know that this is totally equal, then we can skip that. We cannot use RenderStyle::diff for this purpose. It is highly tailored to rendering purpose. And a lof of properties changes are not reported when it is unrelated to layout (but it is necessary for updateCSSTransitions). Example is `top` / `left`. So instead, we have more tailored path collecting necessary properties in this patch. With this patch, we always collect all possible affected properties. So we no longer need to list up all animatable properties. It results in 0.7% progression in Speedometer3. * Source/WebCore/dom/Element.cpp: (WebCore::Element::hasAnimations const): * Source/WebCore/dom/Element.h: * Source/WebCore/dom/ElementRareData.h: (WebCore::ElementRareData::hasAnimations const): * Source/WebCore/style/Styleable.cpp: (WebCore::Styleable::updateCSSTransitions const): Canonical link: https://commits.webkit.org/268412@main

webkit-commit-queue · 2023-09-25T21:42:14Z

Committed 268412@main (66eb8a0): https://commits.webkit.org/268412@main

Reviewed commits have been landed. Closing PR #18054 and removing active labels.

Constellation requested review from cdumez and rniwa as code owners September 21, 2023 23:40

Constellation self-assigned this Sep 21, 2023

Constellation added the Animations Bugs related to CSS + SVG animations and transitions label Sep 21, 2023

cdumez reviewed Sep 21, 2023

View reviewed changes

cdumez requested review from anttijk, graouts and grorg September 21, 2023 23:47

Constellation requested review from alanbaradlay and smfr September 22, 2023 00:10

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 22, 2023

Constellation removed the merging-blocked Applied to prevent a change from being merged label Sep 22, 2023

Constellation force-pushed the eng/CSSTransition-Do-not-list-up-all-properties-when-possible-with-transition-all branch from 793a450 to 0ac729e Compare September 22, 2023 07:00

Constellation marked this pull request as draft September 22, 2023 07:26

Constellation force-pushed the eng/CSSTransition-Do-not-list-up-all-properties-when-possible-with-transition-all branch from 0ac729e to c9ad8e4 Compare September 22, 2023 07:37

Constellation force-pushed the eng/CSSTransition-Do-not-list-up-all-properties-when-possible-with-transition-all branch from c9ad8e4 to ed190dd Compare September 22, 2023 08:34

Constellation force-pushed the eng/CSSTransition-Do-not-list-up-all-properties-when-possible-with-transition-all branch from ed190dd to 6e9008f Compare September 22, 2023 08:40

Constellation force-pushed the eng/CSSTransition-Do-not-list-up-all-properties-when-possible-with-transition-all branch from 6e9008f to fc23ce9 Compare September 22, 2023 10:05

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 22, 2023

Constellation removed the merging-blocked Applied to prevent a change from being merged label Sep 22, 2023

Constellation force-pushed the eng/CSSTransition-Do-not-list-up-all-properties-when-possible-with-transition-all branch from fc23ce9 to c44d5bf Compare September 22, 2023 18:25

Constellation removed the merging-blocked Applied to prevent a change from being merged label Sep 25, 2023

Constellation force-pushed the eng/CSSTransition-Do-not-list-up-all-properties-when-possible-with-transition-all branch from 7253507 to 2cc1a97 Compare September 25, 2023 06:15

Constellation force-pushed the eng/CSSTransition-Do-not-list-up-all-properties-when-possible-with-transition-all branch from 2cc1a97 to 8298c9b Compare September 25, 2023 06:19

Constellation force-pushed the eng/CSSTransition-Do-not-list-up-all-properties-when-possible-with-transition-all branch from 8298c9b to 4ac71ae Compare September 25, 2023 06:39

Constellation changed the title ~~[CSSTransition] Do not list up all properties when possible with transition: all~~ [CSSTransition] Do not list up all properties for transition: all Sep 25, 2023

Constellation force-pushed the eng/CSSTransition-Do-not-list-up-all-properties-when-possible-with-transition-all branch from 4ac71ae to 44e015f Compare September 25, 2023 06:41

Constellation force-pushed the eng/CSSTransition-Do-not-list-up-all-properties-when-possible-with-transition-all branch from 44e015f to 088b81b Compare September 25, 2023 07:06

anttijk reviewed Sep 25, 2023

View reviewed changes

Constellation force-pushed the eng/CSSTransition-Do-not-list-up-all-properties-when-possible-with-transition-all branch from 088b81b to e8ac477 Compare September 25, 2023 16:06

anttijk approved these changes Sep 25, 2023

View reviewed changes

Constellation force-pushed the eng/CSSTransition-Do-not-list-up-all-properties-when-possible-with-transition-all branch from e8ac477 to 3e52d82 Compare September 25, 2023 16:36

anttijk reviewed Sep 25, 2023

View reviewed changes

Constellation force-pushed the eng/CSSTransition-Do-not-list-up-all-properties-when-possible-with-transition-all branch from 3e52d82 to d68e508 Compare September 25, 2023 16:39

Constellation force-pushed the eng/CSSTransition-Do-not-list-up-all-properties-when-possible-with-transition-all branch from d68e508 to a6f45ad Compare September 25, 2023 16:42

Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 25, 2023

webkit-commit-queue force-pushed the eng/CSSTransition-Do-not-list-up-all-properties-when-possible-with-transition-all branch from a6f45ad to 66eb8a0 Compare September 25, 2023 21:42

webkit-commit-queue merged commit 66eb8a0 into WebKit:main Sep 25, 2023

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 25, 2023

Constellation deleted the eng/CSSTransition-Do-not-list-up-all-properties-when-possible-with-transition-all branch September 26, 2023 01:35

Conversation

Constellation commented Sep 21, 2023 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cdumez left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Sep 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Constellation commented Sep 22, 2023

Uh oh!

webkit-early-warning-system commented Sep 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Constellation commented Sep 22, 2023

Uh oh!

webkit-early-warning-system commented Sep 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Constellation Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anttijk Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Constellation commented Sep 21, 2023 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Sep 21, 2023 •

edited

Loading

webkit-early-warning-system commented Sep 22, 2023 •

edited

Loading

webkit-early-warning-system commented Sep 22, 2023 •

edited

Loading

webkit-early-warning-system commented Sep 22, 2023 •

edited

Loading

webkit-early-warning-system commented Sep 22, 2023 •

edited

Loading

webkit-early-warning-system commented Sep 22, 2023 •

edited

Loading

webkit-early-warning-system commented Sep 22, 2023 •

edited

Loading

webkit-early-warning-system commented Sep 25, 2023 •

edited

Loading

webkit-early-warning-system commented Sep 25, 2023 •

edited

Loading

webkit-early-warning-system commented Sep 25, 2023 •

edited

Loading

webkit-early-warning-system commented Sep 25, 2023 •

edited

Loading

webkit-early-warning-system commented Sep 25, 2023 •

edited

Loading

Constellation Sep 25, 2023 •

edited

Loading

anttijk Sep 25, 2023 •

edited

Loading

webkit-early-warning-system commented Sep 25, 2023 •

edited

Loading

webkit-early-warning-system commented Sep 25, 2023 •

edited

Loading

webkit-early-warning-system commented Sep 25, 2023 •

edited

Loading

webkit-early-warning-system commented Sep 25, 2023 •

edited

Loading