Skip to content

Devirtualize many of the renderer type checks#18352

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
cdumez:RenderObject_Type
Sep 28, 2023
Merged

Devirtualize many of the renderer type checks#18352
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
cdumez:RenderObject_Type

Conversation

@cdumez
Copy link
Contributor

@cdumez cdumez commented Sep 28, 2023

7b1df14

Devirtualize many of the renderer type checks
https://bugs.webkit.org/show_bug.cgi?id=262308

Reviewed by Yusuke Suzuki and Ryosuke Niwa.

Add a m_type data member to RenderObject in order to devirtualize most
renderer type checks.

* Source/WebCore/dom/Text.cpp:
(WebCore::Text::createTextRenderer):
* Source/WebCore/html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createElementRenderer):
* Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::createElementRenderer):
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::createElementRenderer):
* Source/WebCore/html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::createElementRenderer):
* Source/WebCore/html/ImageInputType.cpp:
(WebCore::ImageInputType::createInputRenderer):
* Source/WebCore/html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createInputRenderer):
* Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp:
(WebCore::MediaControlTextTrackContainerElement::createElementRenderer):
* Source/WebCore/html/shadow/SliderThumbElement.cpp:
* Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp:
(WebCore::YouTubeEmbedShadowElement::createElementRenderer):
* Source/WebCore/mathml/MathMLAnnotationElement.cpp:
(WebCore::MathMLAnnotationElement::createElementRenderer):
* Source/WebCore/mathml/MathMLOperatorElement.cpp:
(WebCore::MathMLOperatorElement::createElementRenderer):
* Source/WebCore/mathml/MathMLRowElement.cpp:
(WebCore::MathMLRowElement::createElementRenderer):
* Source/WebCore/mathml/MathMLScriptsElement.cpp:
(WebCore::MathMLScriptsElement::createElementRenderer):
* Source/WebCore/mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::createElementRenderer):
* Source/WebCore/mathml/MathMLTokenElement.cpp:
(WebCore::MathMLTokenElement::createElementRenderer):
* Source/WebCore/rendering/RenderAttachment.cpp:
(WebCore::RenderAttachment::RenderAttachment):
* Source/WebCore/rendering/RenderAttachment.h:
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::createAnonymousBlockWithStyleAndDisplay):
* Source/WebCore/rendering/RenderBlock.h:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::RenderBlockFlow):
* Source/WebCore/rendering/RenderBlockFlow.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::RenderBox):
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::RenderBoxModelObject):
* Source/WebCore/rendering/RenderBoxModelObject.h:
* Source/WebCore/rendering/RenderButton.cpp:
(WebCore::RenderButton::RenderButton):
* Source/WebCore/rendering/RenderButton.h:
* Source/WebCore/rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::RenderCombineText):
* Source/WebCore/rendering/RenderCombineText.h:
* Source/WebCore/rendering/RenderCounter.cpp:
(WebCore::RenderCounter::RenderCounter):
(WebCore::RenderCounter::isCounter const): Deleted.
* Source/WebCore/rendering/RenderCounter.h:
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h:
* Source/WebCore/rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::RenderDetailsMarker):
* Source/WebCore/rendering/RenderDetailsMarker.h:
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
(WebCore::RenderElement::createFor):
* Source/WebCore/rendering/RenderElement.h:
* Source/WebCore/rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
* Source/WebCore/rendering/RenderEmbeddedObject.h:
* Source/WebCore/rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::RenderFileUploadControl):
* Source/WebCore/rendering/RenderFileUploadControl.h:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::RenderFlexibleBox):
* Source/WebCore/rendering/RenderFlexibleBox.h:
* Source/WebCore/rendering/RenderFragmentContainer.cpp:
(WebCore::RenderFragmentContainer::RenderFragmentContainer):
* Source/WebCore/rendering/RenderFragmentContainer.h:
* Source/WebCore/rendering/RenderFragmentContainerSet.cpp:
(WebCore::RenderFragmentContainerSet::RenderFragmentContainerSet):
* Source/WebCore/rendering/RenderFragmentContainerSet.h:
* Source/WebCore/rendering/RenderFragmentedFlow.cpp:
(WebCore::RenderFragmentedFlow::RenderFragmentedFlow):
* Source/WebCore/rendering/RenderFragmentedFlow.h:
* Source/WebCore/rendering/RenderFrame.cpp:
(WebCore::RenderFrame::RenderFrame):
* Source/WebCore/rendering/RenderFrame.h:
* Source/WebCore/rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::RenderFrameBase):
* Source/WebCore/rendering/RenderFrameBase.h:
* Source/WebCore/rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::RenderFrameSet):
* Source/WebCore/rendering/RenderFrameSet.h:
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::RenderGrid):
* Source/WebCore/rendering/RenderGrid.h:
* Source/WebCore/rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
* Source/WebCore/rendering/RenderHTMLCanvas.h:
* Source/WebCore/rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::RenderIFrame):
* Source/WebCore/rendering/RenderIFrame.h:
* Source/WebCore/rendering/RenderImage.cpp:
(WebCore::RenderImage::RenderImage):
* Source/WebCore/rendering/RenderImage.h:
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::RenderInline):
* Source/WebCore/rendering/RenderInline.h:
* Source/WebCore/rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::RenderLayerModelObject):
* Source/WebCore/rendering/RenderLayerModelObject.h:
* Source/WebCore/rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::RenderLineBreak):
* Source/WebCore/rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
* Source/WebCore/rendering/RenderListBox.h:
* Source/WebCore/rendering/RenderListItem.cpp:
(WebCore::RenderListItem::RenderListItem):
* Source/WebCore/rendering/RenderListItem.h:
* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::RenderListMarker):
* Source/WebCore/rendering/RenderListMarker.h:
* Source/WebCore/rendering/RenderMedia.cpp:
(WebCore::RenderMedia::RenderMedia):
* Source/WebCore/rendering/RenderMedia.h:
* Source/WebCore/rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::RenderMenuList):
(RenderMenuList::setText):
* Source/WebCore/rendering/RenderMenuList.h:
* Source/WebCore/rendering/RenderMeter.cpp:
(WebCore::RenderMeter::RenderMeter):
* Source/WebCore/rendering/RenderMeter.h:
* Source/WebCore/rendering/RenderModel.cpp:
(WebCore::RenderModel::RenderModel):
* Source/WebCore/rendering/RenderModel.h:
* Source/WebCore/rendering/RenderMultiColumnFlow.cpp:
(WebCore::RenderMultiColumnFlow::RenderMultiColumnFlow):
* Source/WebCore/rendering/RenderMultiColumnFlow.h:
* Source/WebCore/rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
* Source/WebCore/rendering/RenderMultiColumnSet.h:
* Source/WebCore/rendering/RenderMultiColumnSpannerPlaceholder.cpp:
(WebCore::RenderMultiColumnSpannerPlaceholder::RenderMultiColumnSpannerPlaceholder):
* Source/WebCore/rendering/RenderMultiColumnSpannerPlaceholder.h:
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::type const):
(WebCore::RenderObject::nextSibling const):
(WebCore::RenderObject::isCounter const):
(WebCore::RenderObject::isQuote const):
(WebCore::RenderObject::isDetailsMarker const):
(WebCore::RenderObject::isEmbeddedObject const):
(WebCore::RenderObject::isFileUploadControl const):
(WebCore::RenderObject::isFrame const):
(WebCore::RenderObject::isFrameSet const):
(WebCore::RenderObject::isListBox const):
(WebCore::RenderObject::isListItem const):
(WebCore::RenderObject::isListMarker const):
(WebCore::RenderObject::isMenuList const):
(WebCore::RenderObject::isMeter const):
(WebCore::RenderObject::isProgress const):
(WebCore::RenderObject::isRenderButton const):
(WebCore::RenderObject::isRenderIFrame const):
(WebCore::RenderObject::isTextFragment const):
(WebCore::RenderObject::isRenderModel const):
(WebCore::RenderObject::isReplica const):
(WebCore::RenderObject::isRubyInline const):
(WebCore::RenderObject::isRubyBlock const):
(WebCore::RenderObject::isRubyBase const):
(WebCore::RenderObject::isRubyRun const):
(WebCore::RenderObject::isRubyText const):
(WebCore::RenderObject::isSlider const):
(WebCore::RenderObject::isTableCell const):
(WebCore::RenderObject::isRenderTableCol const):
(WebCore::RenderObject::isTableCaption const):
(WebCore::RenderObject::isTableSection const):
(WebCore::RenderObject::isTextArea const):
(WebCore::RenderObject::isSearchField const):
(WebCore::RenderObject::isTextControlInnerBlock const):
(WebCore::RenderObject::isVideo const):
(WebCore::RenderObject::isCanvas const):
(WebCore::RenderObject::isAttachment const):
(WebCore::RenderObject::isRenderGrid const):
(WebCore::RenderObject::isRenderMultiColumnSet const):
(WebCore::RenderObject::isRenderMultiColumnFlow const):
(WebCore::RenderObject::isRenderMultiColumnSpannerPlaceholder const):
(WebCore::RenderObject::isRenderScrollbarPart const):
(WebCore::RenderObject::isRenderVTTCue const):
(WebCore::RenderObject::isRenderMathMLTable const):
(WebCore::RenderObject::isRenderMathMLMath const):
(WebCore::RenderObject::isRenderMathMLMenclose const):
(WebCore::RenderObject::isRenderMathMLFenced const):
(WebCore::RenderObject::isRenderMathMLFencedOperator const):
(WebCore::RenderObject::isRenderMathMLFraction const):
(WebCore::RenderObject::isRenderMathMLPadded const):
(WebCore::RenderObject::isRenderMathMLRoot const):
(WebCore::RenderObject::isRenderMathMLSpace const):
(WebCore::RenderObject::isRenderMathMLUnderOver const):
(WebCore::RenderObject::isRenderSVGBlock const):
(WebCore::RenderObject::isLegacySVGRoot const):
(WebCore::RenderObject::isSVGRoot const):
(WebCore::RenderObject::isSVGTransformableContainer const):
(WebCore::RenderObject::isLegacySVGTransformableContainer const):
(WebCore::RenderObject::isSVGViewportContainer const):
(WebCore::RenderObject::isLegacySVGViewportContainer const):
(WebCore::RenderObject::isSVGGradientStop const):
(WebCore::RenderObject::isSVGHiddenContainer const):
(WebCore::RenderObject::isLegacySVGPath const):
(WebCore::RenderObject::isSVGPath const):
(WebCore::RenderObject::isSVGText const):
(WebCore::RenderObject::isSVGTextPath const):
(WebCore::RenderObject::isSVGTSpan const):
(WebCore::RenderObject::isSVGInline const):
(WebCore::RenderObject::isSVGInlineText const):
(WebCore::RenderObject::isLegacySVGImage const):
(WebCore::RenderObject::isSVGImage const):
(WebCore::RenderObject::isLegacySVGForeignObject const):
(WebCore::RenderObject::isSVGForeignObject const):
(WebCore::RenderObject::isSVGResourceFilter const):
(WebCore::RenderObject::isSVGResourceClipper const):
(WebCore::RenderObject::isSVGResourceFilterPrimitive const):
(WebCore::RenderObject::isText const):
(WebCore::RenderObject::isLineBreak const):
(WebCore::RenderObject::isTableRow const):
(WebCore::RenderObject::isRenderView const):
(WebCore::RenderObject::setIsText):
(WebCore::RenderObject::setIsBox):
(WebCore::RenderObject::isCombineText const):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(WebCore::RenderObject::isRenderMathMLRow const):
(WebCore::RenderObject::setIsLineBreak): Deleted.
(WebCore::RenderObject::setIsTableRow): Deleted.
(WebCore::RenderObject::setIsRenderView): Deleted.
* Source/WebCore/rendering/RenderProgress.cpp:
(WebCore::RenderProgress::RenderProgress):
* Source/WebCore/rendering/RenderProgress.h:
* Source/WebCore/rendering/RenderQuote.cpp:
(WebCore::RenderQuote::RenderQuote):
* Source/WebCore/rendering/RenderQuote.h:
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::RenderReplaced):
* Source/WebCore/rendering/RenderReplaced.h:
* Source/WebCore/rendering/RenderReplica.cpp:
(WebCore::RenderReplica::RenderReplica):
* Source/WebCore/rendering/RenderReplica.h:
* Source/WebCore/rendering/RenderRuby.cpp:
(WebCore::RenderRubyAsInline::RenderRubyAsInline):
(WebCore::RenderRubyAsBlock::RenderRubyAsBlock):
* Source/WebCore/rendering/RenderRuby.h:
* Source/WebCore/rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::RenderRubyBase):
* Source/WebCore/rendering/RenderRubyBase.h:
* Source/WebCore/rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::RenderRubyRun):
* Source/WebCore/rendering/RenderRubyRun.h:
* Source/WebCore/rendering/RenderRubyText.cpp:
(WebCore::RenderRubyText::RenderRubyText):
* Source/WebCore/rendering/RenderRubyText.h:
* Source/WebCore/rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::RenderScrollbarPart):
* Source/WebCore/rendering/RenderScrollbarPart.h:
* Source/WebCore/rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::RenderSearchField):
* Source/WebCore/rendering/RenderSearchField.h:
* Source/WebCore/rendering/RenderSlider.cpp:
(WebCore::RenderSlider::RenderSlider):
* Source/WebCore/rendering/RenderSlider.h:
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::createTableWithStyle):
* Source/WebCore/rendering/RenderTable.h:
* Source/WebCore/rendering/RenderTableCaption.cpp:
(WebCore::RenderTableCaption::RenderTableCaption):
* Source/WebCore/rendering/RenderTableCaption.h:
* Source/WebCore/rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::RenderTableCell):
* Source/WebCore/rendering/RenderTableCell.h:
* Source/WebCore/rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::RenderTableCol):
* Source/WebCore/rendering/RenderTableCol.h:
* Source/WebCore/rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::RenderTableRow):
* Source/WebCore/rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::RenderTableSection):
* Source/WebCore/rendering/RenderTableSection.h:
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::RenderText):
(WebCore::RenderText::isTextFragment const): Deleted.
* Source/WebCore/rendering/RenderText.h:
* Source/WebCore/rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl):
(WebCore::RenderTextControlInnerContainer::RenderTextControlInnerContainer):
* Source/WebCore/rendering/RenderTextControl.h:
* Source/WebCore/rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
* Source/WebCore/rendering/RenderTextControlMultiLine.h:
* Source/WebCore/rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
* Source/WebCore/rendering/RenderTextControlSingleLine.h:
* Source/WebCore/rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::RenderTextFragment):
* Source/WebCore/rendering/RenderTextFragment.h:
* Source/WebCore/rendering/RenderVTTCue.cpp:
(WebCore::RenderVTTCue::RenderVTTCue):
* Source/WebCore/rendering/RenderVTTCue.h:
* Source/WebCore/rendering/RenderVideo.cpp:
(WebCore::RenderVideo::RenderVideo):
* Source/WebCore/rendering/RenderVideo.h:
* Source/WebCore/rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
* Source/WebCore/rendering/RenderWidget.cpp:
(WebCore::RenderWidget::RenderWidget):
* Source/WebCore/rendering/RenderWidget.h:
* Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
* Source/WebCore/rendering/mathml/RenderMathMLBlock.h:
* Source/WebCore/rendering/mathml/RenderMathMLBlockInlines.h:
(WebCore::RenderMathMLTable::RenderMathMLTable):
* Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::RenderMathMLFenced):
* Source/WebCore/rendering/mathml/RenderMathMLFenced.h:
* Source/WebCore/rendering/mathml/RenderMathMLFencedOperator.cpp:
(WebCore::RenderMathMLFencedOperator::RenderMathMLFencedOperator):
* Source/WebCore/rendering/mathml/RenderMathMLFencedOperator.h:
* Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::RenderMathMLFraction):
* Source/WebCore/rendering/mathml/RenderMathMLFraction.h:
* Source/WebCore/rendering/mathml/RenderMathMLMath.cpp:
(WebCore::RenderMathMLMath::RenderMathMLMath):
* Source/WebCore/rendering/mathml/RenderMathMLMath.h:
* Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp:
(WebCore::RenderMathMLMenclose::RenderMathMLMenclose):
* Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
* Source/WebCore/rendering/mathml/RenderMathMLOperator.h:
* Source/WebCore/rendering/mathml/RenderMathMLPadded.cpp:
(WebCore::RenderMathMLPadded::RenderMathMLPadded):
* Source/WebCore/rendering/mathml/RenderMathMLPadded.h:
* Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::RenderMathMLRoot):
* Source/WebCore/rendering/mathml/RenderMathMLRoot.h:
* Source/WebCore/rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::RenderMathMLRow):
* Source/WebCore/rendering/mathml/RenderMathMLRow.h:
* Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::RenderMathMLScripts):
* Source/WebCore/rendering/mathml/RenderMathMLScripts.h:
* Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:
(WebCore::RenderMathMLSpace::RenderMathMLSpace):
* Source/WebCore/rendering/mathml/RenderMathMLSpace.h:
* Source/WebCore/rendering/mathml/RenderMathMLToken.cpp:
(WebCore::RenderMathMLToken::RenderMathMLToken):
* Source/WebCore/rendering/mathml/RenderMathMLToken.h:
* Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::RenderMathMLUnderOver):
* Source/WebCore/rendering/mathml/RenderMathMLUnderOver.h:
* Source/WebCore/rendering/style/ContentData.cpp:
(WebCore::ImageContentData::createContentRenderer const):
* Source/WebCore/rendering/svg/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::RenderSVGBlock):
* Source/WebCore/rendering/svg/RenderSVGBlock.h:
* Source/WebCore/rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::RenderSVGContainer):
* Source/WebCore/rendering/svg/RenderSVGContainer.h:
* Source/WebCore/rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::RenderSVGEllipse):
* Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::RenderSVGForeignObject):
* Source/WebCore/rendering/svg/RenderSVGForeignObject.h:
* Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp:
(WebCore::RenderSVGGradientStop::RenderSVGGradientStop):
* Source/WebCore/rendering/svg/RenderSVGGradientStop.h:
* Source/WebCore/rendering/svg/RenderSVGHiddenContainer.cpp:
(WebCore::RenderSVGHiddenContainer::RenderSVGHiddenContainer):
* Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h:
* Source/WebCore/rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::RenderSVGImage):
* Source/WebCore/rendering/svg/RenderSVGImage.h:
* Source/WebCore/rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::RenderSVGInline):
* Source/WebCore/rendering/svg/RenderSVGInline.h:
* Source/WebCore/rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::RenderSVGInlineText):
* Source/WebCore/rendering/svg/RenderSVGInlineText.h:
* Source/WebCore/rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::RenderSVGModelObject):
* Source/WebCore/rendering/svg/RenderSVGModelObject.h:
* Source/WebCore/rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::RenderSVGPath):
* Source/WebCore/rendering/svg/RenderSVGPath.h:
* Source/WebCore/rendering/svg/RenderSVGRect.cpp:
(WebCore::RenderSVGRect::RenderSVGRect):
* Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter):
* Source/WebCore/rendering/svg/RenderSVGResourceFilter.h:
* Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::RenderSVGResourceFilterPrimitive):
* Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h:
* Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient):
* Source/WebCore/rendering/svg/RenderSVGResourceGradient.h:
* Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.cpp:
(WebCore::RenderSVGResourceLinearGradient::RenderSVGResourceLinearGradient):
* Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp:
(WebCore::RenderSVGResourceMarker::RenderSVGResourceMarker):
* Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::RenderSVGResourceMasker):
* Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::RenderSVGResourcePattern):
* Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.cpp:
(WebCore::RenderSVGResourceRadialGradient::RenderSVGResourceRadialGradient):
* Source/WebCore/rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::RenderSVGRoot):
* Source/WebCore/rendering/svg/RenderSVGRoot.h:
* Source/WebCore/rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::RenderSVGShape):
* Source/WebCore/rendering/svg/RenderSVGShape.h:
* Source/WebCore/rendering/svg/RenderSVGTSpan.h:
* Source/WebCore/rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::RenderSVGText):
* Source/WebCore/rendering/svg/RenderSVGText.h:
* Source/WebCore/rendering/svg/RenderSVGTextPath.cpp:
(WebCore::RenderSVGTextPath::RenderSVGTextPath):
* Source/WebCore/rendering/svg/RenderSVGTextPath.h:
* Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp:
(WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer):
* Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h:
* Source/WebCore/rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
* Source/WebCore/rendering/svg/RenderSVGViewportContainer.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.cpp:
(WebCore::LegacyRenderSVGContainer::LegacyRenderSVGContainer):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGEllipse.cpp:
(WebCore::LegacyRenderSVGEllipse::LegacyRenderSVGEllipse):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.cpp:
(WebCore::LegacyRenderSVGForeignObject::LegacyRenderSVGForeignObject):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGHiddenContainer.cpp:
(WebCore::LegacyRenderSVGHiddenContainer::LegacyRenderSVGHiddenContainer):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGHiddenContainer.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.cpp:
(WebCore::LegacyRenderSVGImage::LegacyRenderSVGImage):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp:
(WebCore::LegacyRenderSVGModelObject::LegacyRenderSVGModelObject):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.cpp:
(WebCore::LegacyRenderSVGPath::LegacyRenderSVGPath):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRect.cpp:
(WebCore::LegacyRenderSVGRect::LegacyRenderSVGRect):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.cpp:
(WebCore::LegacyRenderSVGResourceClipper::LegacyRenderSVGResourceClipper):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceContainer.cpp:
(WebCore::LegacyRenderSVGResourceContainer::LegacyRenderSVGResourceContainer):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceContainer.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp:
(WebCore::LegacyRenderSVGRoot::LegacyRenderSVGRoot):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp:
(WebCore::LegacyRenderSVGShape::LegacyRenderSVGShape):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGTransformableContainer.cpp:
(WebCore::LegacyRenderSVGTransformableContainer::LegacyRenderSVGTransformableContainer):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGTransformableContainer.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGViewportContainer.cpp:
(WebCore::LegacyRenderSVGViewportContainer::LegacyRenderSVGViewportContainer):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGViewportContainer.h:
* Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp:
(WebCore::RenderTreeBuilder::FirstLetter::updateStyle):
(WebCore::RenderTreeBuilder::FirstLetter::createRenderers):
* Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp:
(WebCore::cloneAsContinuation):
(WebCore::RenderTreeBuilder::Inline::attachIgnoringContinuation):
* Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp:
(WebCore::createAnonymousRubyInlineBlock):
(WebCore::RenderTreeBuilder::Ruby::findOrCreateParentForStyleBasedRubyChild):
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::createTextRenderer):
* Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:
(WebCore::RenderTreeUpdater::GeneratedContent::updateBackdropRenderer):
* Source/WebCore/svg/SVGAElement.cpp:
(WebCore::SVGAElement::createElementRenderer):
* Source/WebCore/svg/SVGDefsElement.cpp:
(WebCore::SVGDefsElement::createElementRenderer):
* Source/WebCore/svg/SVGGElement.cpp:
(WebCore::SVGGElement::createElementRenderer):
* Source/WebCore/svg/SVGSymbolElement.cpp:
(WebCore::SVGSymbolElement::createElementRenderer):
* Source/WebCore/svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::createElementRenderer):

Canonical link: https://commits.webkit.org/268604@main

1ef4870

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Sep 28, 2023
@cdumez cdumez added the Layout and Rendering For bugs with layout and rendering of Web pages. label Sep 28, 2023
@cdumez cdumez marked this pull request as ready for review September 28, 2023 16:49
@cdumez cdumez requested a review from rniwa as a code owner September 28, 2023 16:49
@cdumez cdumez requested review from alanbaradlay, anttijk, rniwa and smfr and removed request for rniwa September 28, 2023 16:49
@cdumez
Copy link
Contributor Author

cdumez commented Sep 28, 2023

This is a 0.7% progression on Speedometer 3 (98% confidence).

Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, nice!

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 28, 2023
https://bugs.webkit.org/show_bug.cgi?id=262308

Reviewed by Yusuke Suzuki and Ryosuke Niwa.

Add a m_type data member to RenderObject in order to devirtualize most
renderer type checks.

* Source/WebCore/dom/Text.cpp:
(WebCore::Text::createTextRenderer):
* Source/WebCore/html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createElementRenderer):
* Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::createElementRenderer):
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::createElementRenderer):
* Source/WebCore/html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::createElementRenderer):
* Source/WebCore/html/ImageInputType.cpp:
(WebCore::ImageInputType::createInputRenderer):
* Source/WebCore/html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createInputRenderer):
* Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp:
(WebCore::MediaControlTextTrackContainerElement::createElementRenderer):
* Source/WebCore/html/shadow/SliderThumbElement.cpp:
* Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp:
(WebCore::YouTubeEmbedShadowElement::createElementRenderer):
* Source/WebCore/mathml/MathMLAnnotationElement.cpp:
(WebCore::MathMLAnnotationElement::createElementRenderer):
* Source/WebCore/mathml/MathMLOperatorElement.cpp:
(WebCore::MathMLOperatorElement::createElementRenderer):
* Source/WebCore/mathml/MathMLRowElement.cpp:
(WebCore::MathMLRowElement::createElementRenderer):
* Source/WebCore/mathml/MathMLScriptsElement.cpp:
(WebCore::MathMLScriptsElement::createElementRenderer):
* Source/WebCore/mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::createElementRenderer):
* Source/WebCore/mathml/MathMLTokenElement.cpp:
(WebCore::MathMLTokenElement::createElementRenderer):
* Source/WebCore/rendering/RenderAttachment.cpp:
(WebCore::RenderAttachment::RenderAttachment):
* Source/WebCore/rendering/RenderAttachment.h:
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::createAnonymousBlockWithStyleAndDisplay):
* Source/WebCore/rendering/RenderBlock.h:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::RenderBlockFlow):
* Source/WebCore/rendering/RenderBlockFlow.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::RenderBox):
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::RenderBoxModelObject):
* Source/WebCore/rendering/RenderBoxModelObject.h:
* Source/WebCore/rendering/RenderButton.cpp:
(WebCore::RenderButton::RenderButton):
* Source/WebCore/rendering/RenderButton.h:
* Source/WebCore/rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::RenderCombineText):
* Source/WebCore/rendering/RenderCombineText.h:
* Source/WebCore/rendering/RenderCounter.cpp:
(WebCore::RenderCounter::RenderCounter):
(WebCore::RenderCounter::isCounter const): Deleted.
* Source/WebCore/rendering/RenderCounter.h:
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h:
* Source/WebCore/rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::RenderDetailsMarker):
* Source/WebCore/rendering/RenderDetailsMarker.h:
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
(WebCore::RenderElement::createFor):
* Source/WebCore/rendering/RenderElement.h:
* Source/WebCore/rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
* Source/WebCore/rendering/RenderEmbeddedObject.h:
* Source/WebCore/rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::RenderFileUploadControl):
* Source/WebCore/rendering/RenderFileUploadControl.h:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::RenderFlexibleBox):
* Source/WebCore/rendering/RenderFlexibleBox.h:
* Source/WebCore/rendering/RenderFragmentContainer.cpp:
(WebCore::RenderFragmentContainer::RenderFragmentContainer):
* Source/WebCore/rendering/RenderFragmentContainer.h:
* Source/WebCore/rendering/RenderFragmentContainerSet.cpp:
(WebCore::RenderFragmentContainerSet::RenderFragmentContainerSet):
* Source/WebCore/rendering/RenderFragmentContainerSet.h:
* Source/WebCore/rendering/RenderFragmentedFlow.cpp:
(WebCore::RenderFragmentedFlow::RenderFragmentedFlow):
* Source/WebCore/rendering/RenderFragmentedFlow.h:
* Source/WebCore/rendering/RenderFrame.cpp:
(WebCore::RenderFrame::RenderFrame):
* Source/WebCore/rendering/RenderFrame.h:
* Source/WebCore/rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::RenderFrameBase):
* Source/WebCore/rendering/RenderFrameBase.h:
* Source/WebCore/rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::RenderFrameSet):
* Source/WebCore/rendering/RenderFrameSet.h:
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::RenderGrid):
* Source/WebCore/rendering/RenderGrid.h:
* Source/WebCore/rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
* Source/WebCore/rendering/RenderHTMLCanvas.h:
* Source/WebCore/rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::RenderIFrame):
* Source/WebCore/rendering/RenderIFrame.h:
* Source/WebCore/rendering/RenderImage.cpp:
(WebCore::RenderImage::RenderImage):
* Source/WebCore/rendering/RenderImage.h:
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::RenderInline):
* Source/WebCore/rendering/RenderInline.h:
* Source/WebCore/rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::RenderLayerModelObject):
* Source/WebCore/rendering/RenderLayerModelObject.h:
* Source/WebCore/rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::RenderLineBreak):
* Source/WebCore/rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
* Source/WebCore/rendering/RenderListBox.h:
* Source/WebCore/rendering/RenderListItem.cpp:
(WebCore::RenderListItem::RenderListItem):
* Source/WebCore/rendering/RenderListItem.h:
* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::RenderListMarker):
* Source/WebCore/rendering/RenderListMarker.h:
* Source/WebCore/rendering/RenderMedia.cpp:
(WebCore::RenderMedia::RenderMedia):
* Source/WebCore/rendering/RenderMedia.h:
* Source/WebCore/rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::RenderMenuList):
(RenderMenuList::setText):
* Source/WebCore/rendering/RenderMenuList.h:
* Source/WebCore/rendering/RenderMeter.cpp:
(WebCore::RenderMeter::RenderMeter):
* Source/WebCore/rendering/RenderMeter.h:
* Source/WebCore/rendering/RenderModel.cpp:
(WebCore::RenderModel::RenderModel):
* Source/WebCore/rendering/RenderModel.h:
* Source/WebCore/rendering/RenderMultiColumnFlow.cpp:
(WebCore::RenderMultiColumnFlow::RenderMultiColumnFlow):
* Source/WebCore/rendering/RenderMultiColumnFlow.h:
* Source/WebCore/rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
* Source/WebCore/rendering/RenderMultiColumnSet.h:
* Source/WebCore/rendering/RenderMultiColumnSpannerPlaceholder.cpp:
(WebCore::RenderMultiColumnSpannerPlaceholder::RenderMultiColumnSpannerPlaceholder):
* Source/WebCore/rendering/RenderMultiColumnSpannerPlaceholder.h:
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::type const):
(WebCore::RenderObject::nextSibling const):
(WebCore::RenderObject::isCounter const):
(WebCore::RenderObject::isQuote const):
(WebCore::RenderObject::isDetailsMarker const):
(WebCore::RenderObject::isEmbeddedObject const):
(WebCore::RenderObject::isFileUploadControl const):
(WebCore::RenderObject::isFrame const):
(WebCore::RenderObject::isFrameSet const):
(WebCore::RenderObject::isListBox const):
(WebCore::RenderObject::isListItem const):
(WebCore::RenderObject::isListMarker const):
(WebCore::RenderObject::isMenuList const):
(WebCore::RenderObject::isMeter const):
(WebCore::RenderObject::isProgress const):
(WebCore::RenderObject::isRenderButton const):
(WebCore::RenderObject::isRenderIFrame const):
(WebCore::RenderObject::isTextFragment const):
(WebCore::RenderObject::isRenderModel const):
(WebCore::RenderObject::isReplica const):
(WebCore::RenderObject::isRubyInline const):
(WebCore::RenderObject::isRubyBlock const):
(WebCore::RenderObject::isRubyBase const):
(WebCore::RenderObject::isRubyRun const):
(WebCore::RenderObject::isRubyText const):
(WebCore::RenderObject::isSlider const):
(WebCore::RenderObject::isTableCell const):
(WebCore::RenderObject::isRenderTableCol const):
(WebCore::RenderObject::isTableCaption const):
(WebCore::RenderObject::isTableSection const):
(WebCore::RenderObject::isTextArea const):
(WebCore::RenderObject::isSearchField const):
(WebCore::RenderObject::isTextControlInnerBlock const):
(WebCore::RenderObject::isVideo const):
(WebCore::RenderObject::isCanvas const):
(WebCore::RenderObject::isAttachment const):
(WebCore::RenderObject::isRenderGrid const):
(WebCore::RenderObject::isRenderMultiColumnSet const):
(WebCore::RenderObject::isRenderMultiColumnFlow const):
(WebCore::RenderObject::isRenderMultiColumnSpannerPlaceholder const):
(WebCore::RenderObject::isRenderScrollbarPart const):
(WebCore::RenderObject::isRenderVTTCue const):
(WebCore::RenderObject::isRenderMathMLTable const):
(WebCore::RenderObject::isRenderMathMLMath const):
(WebCore::RenderObject::isRenderMathMLMenclose const):
(WebCore::RenderObject::isRenderMathMLFenced const):
(WebCore::RenderObject::isRenderMathMLFencedOperator const):
(WebCore::RenderObject::isRenderMathMLFraction const):
(WebCore::RenderObject::isRenderMathMLPadded const):
(WebCore::RenderObject::isRenderMathMLRoot const):
(WebCore::RenderObject::isRenderMathMLSpace const):
(WebCore::RenderObject::isRenderMathMLUnderOver const):
(WebCore::RenderObject::isRenderSVGBlock const):
(WebCore::RenderObject::isLegacySVGRoot const):
(WebCore::RenderObject::isSVGRoot const):
(WebCore::RenderObject::isSVGTransformableContainer const):
(WebCore::RenderObject::isLegacySVGTransformableContainer const):
(WebCore::RenderObject::isSVGViewportContainer const):
(WebCore::RenderObject::isLegacySVGViewportContainer const):
(WebCore::RenderObject::isSVGGradientStop const):
(WebCore::RenderObject::isSVGHiddenContainer const):
(WebCore::RenderObject::isLegacySVGPath const):
(WebCore::RenderObject::isSVGPath const):
(WebCore::RenderObject::isSVGText const):
(WebCore::RenderObject::isSVGTextPath const):
(WebCore::RenderObject::isSVGTSpan const):
(WebCore::RenderObject::isSVGInline const):
(WebCore::RenderObject::isSVGInlineText const):
(WebCore::RenderObject::isLegacySVGImage const):
(WebCore::RenderObject::isSVGImage const):
(WebCore::RenderObject::isLegacySVGForeignObject const):
(WebCore::RenderObject::isSVGForeignObject const):
(WebCore::RenderObject::isSVGResourceFilter const):
(WebCore::RenderObject::isSVGResourceClipper const):
(WebCore::RenderObject::isSVGResourceFilterPrimitive const):
(WebCore::RenderObject::isText const):
(WebCore::RenderObject::isLineBreak const):
(WebCore::RenderObject::isTableRow const):
(WebCore::RenderObject::isRenderView const):
(WebCore::RenderObject::setIsText):
(WebCore::RenderObject::setIsBox):
(WebCore::RenderObject::isCombineText const):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(WebCore::RenderObject::isRenderMathMLRow const):
(WebCore::RenderObject::setIsLineBreak): Deleted.
(WebCore::RenderObject::setIsTableRow): Deleted.
(WebCore::RenderObject::setIsRenderView): Deleted.
* Source/WebCore/rendering/RenderProgress.cpp:
(WebCore::RenderProgress::RenderProgress):
* Source/WebCore/rendering/RenderProgress.h:
* Source/WebCore/rendering/RenderQuote.cpp:
(WebCore::RenderQuote::RenderQuote):
* Source/WebCore/rendering/RenderQuote.h:
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::RenderReplaced):
* Source/WebCore/rendering/RenderReplaced.h:
* Source/WebCore/rendering/RenderReplica.cpp:
(WebCore::RenderReplica::RenderReplica):
* Source/WebCore/rendering/RenderReplica.h:
* Source/WebCore/rendering/RenderRuby.cpp:
(WebCore::RenderRubyAsInline::RenderRubyAsInline):
(WebCore::RenderRubyAsBlock::RenderRubyAsBlock):
* Source/WebCore/rendering/RenderRuby.h:
* Source/WebCore/rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::RenderRubyBase):
* Source/WebCore/rendering/RenderRubyBase.h:
* Source/WebCore/rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::RenderRubyRun):
* Source/WebCore/rendering/RenderRubyRun.h:
* Source/WebCore/rendering/RenderRubyText.cpp:
(WebCore::RenderRubyText::RenderRubyText):
* Source/WebCore/rendering/RenderRubyText.h:
* Source/WebCore/rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::RenderScrollbarPart):
* Source/WebCore/rendering/RenderScrollbarPart.h:
* Source/WebCore/rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::RenderSearchField):
* Source/WebCore/rendering/RenderSearchField.h:
* Source/WebCore/rendering/RenderSlider.cpp:
(WebCore::RenderSlider::RenderSlider):
* Source/WebCore/rendering/RenderSlider.h:
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::createTableWithStyle):
* Source/WebCore/rendering/RenderTable.h:
* Source/WebCore/rendering/RenderTableCaption.cpp:
(WebCore::RenderTableCaption::RenderTableCaption):
* Source/WebCore/rendering/RenderTableCaption.h:
* Source/WebCore/rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::RenderTableCell):
* Source/WebCore/rendering/RenderTableCell.h:
* Source/WebCore/rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::RenderTableCol):
* Source/WebCore/rendering/RenderTableCol.h:
* Source/WebCore/rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::RenderTableRow):
* Source/WebCore/rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::RenderTableSection):
* Source/WebCore/rendering/RenderTableSection.h:
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::RenderText):
(WebCore::RenderText::isTextFragment const): Deleted.
* Source/WebCore/rendering/RenderText.h:
* Source/WebCore/rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl):
(WebCore::RenderTextControlInnerContainer::RenderTextControlInnerContainer):
* Source/WebCore/rendering/RenderTextControl.h:
* Source/WebCore/rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
* Source/WebCore/rendering/RenderTextControlMultiLine.h:
* Source/WebCore/rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
* Source/WebCore/rendering/RenderTextControlSingleLine.h:
* Source/WebCore/rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::RenderTextFragment):
* Source/WebCore/rendering/RenderTextFragment.h:
* Source/WebCore/rendering/RenderVTTCue.cpp:
(WebCore::RenderVTTCue::RenderVTTCue):
* Source/WebCore/rendering/RenderVTTCue.h:
* Source/WebCore/rendering/RenderVideo.cpp:
(WebCore::RenderVideo::RenderVideo):
* Source/WebCore/rendering/RenderVideo.h:
* Source/WebCore/rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
* Source/WebCore/rendering/RenderWidget.cpp:
(WebCore::RenderWidget::RenderWidget):
* Source/WebCore/rendering/RenderWidget.h:
* Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
* Source/WebCore/rendering/mathml/RenderMathMLBlock.h:
* Source/WebCore/rendering/mathml/RenderMathMLBlockInlines.h:
(WebCore::RenderMathMLTable::RenderMathMLTable):
* Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::RenderMathMLFenced):
* Source/WebCore/rendering/mathml/RenderMathMLFenced.h:
* Source/WebCore/rendering/mathml/RenderMathMLFencedOperator.cpp:
(WebCore::RenderMathMLFencedOperator::RenderMathMLFencedOperator):
* Source/WebCore/rendering/mathml/RenderMathMLFencedOperator.h:
* Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::RenderMathMLFraction):
* Source/WebCore/rendering/mathml/RenderMathMLFraction.h:
* Source/WebCore/rendering/mathml/RenderMathMLMath.cpp:
(WebCore::RenderMathMLMath::RenderMathMLMath):
* Source/WebCore/rendering/mathml/RenderMathMLMath.h:
* Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp:
(WebCore::RenderMathMLMenclose::RenderMathMLMenclose):
* Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
* Source/WebCore/rendering/mathml/RenderMathMLOperator.h:
* Source/WebCore/rendering/mathml/RenderMathMLPadded.cpp:
(WebCore::RenderMathMLPadded::RenderMathMLPadded):
* Source/WebCore/rendering/mathml/RenderMathMLPadded.h:
* Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::RenderMathMLRoot):
* Source/WebCore/rendering/mathml/RenderMathMLRoot.h:
* Source/WebCore/rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::RenderMathMLRow):
* Source/WebCore/rendering/mathml/RenderMathMLRow.h:
* Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::RenderMathMLScripts):
* Source/WebCore/rendering/mathml/RenderMathMLScripts.h:
* Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:
(WebCore::RenderMathMLSpace::RenderMathMLSpace):
* Source/WebCore/rendering/mathml/RenderMathMLSpace.h:
* Source/WebCore/rendering/mathml/RenderMathMLToken.cpp:
(WebCore::RenderMathMLToken::RenderMathMLToken):
* Source/WebCore/rendering/mathml/RenderMathMLToken.h:
* Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::RenderMathMLUnderOver):
* Source/WebCore/rendering/mathml/RenderMathMLUnderOver.h:
* Source/WebCore/rendering/style/ContentData.cpp:
(WebCore::ImageContentData::createContentRenderer const):
* Source/WebCore/rendering/svg/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::RenderSVGBlock):
* Source/WebCore/rendering/svg/RenderSVGBlock.h:
* Source/WebCore/rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::RenderSVGContainer):
* Source/WebCore/rendering/svg/RenderSVGContainer.h:
* Source/WebCore/rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::RenderSVGEllipse):
* Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::RenderSVGForeignObject):
* Source/WebCore/rendering/svg/RenderSVGForeignObject.h:
* Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp:
(WebCore::RenderSVGGradientStop::RenderSVGGradientStop):
* Source/WebCore/rendering/svg/RenderSVGGradientStop.h:
* Source/WebCore/rendering/svg/RenderSVGHiddenContainer.cpp:
(WebCore::RenderSVGHiddenContainer::RenderSVGHiddenContainer):
* Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h:
* Source/WebCore/rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::RenderSVGImage):
* Source/WebCore/rendering/svg/RenderSVGImage.h:
* Source/WebCore/rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::RenderSVGInline):
* Source/WebCore/rendering/svg/RenderSVGInline.h:
* Source/WebCore/rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::RenderSVGInlineText):
* Source/WebCore/rendering/svg/RenderSVGInlineText.h:
* Source/WebCore/rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::RenderSVGModelObject):
* Source/WebCore/rendering/svg/RenderSVGModelObject.h:
* Source/WebCore/rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::RenderSVGPath):
* Source/WebCore/rendering/svg/RenderSVGPath.h:
* Source/WebCore/rendering/svg/RenderSVGRect.cpp:
(WebCore::RenderSVGRect::RenderSVGRect):
* Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter):
* Source/WebCore/rendering/svg/RenderSVGResourceFilter.h:
* Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::RenderSVGResourceFilterPrimitive):
* Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h:
* Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient):
* Source/WebCore/rendering/svg/RenderSVGResourceGradient.h:
* Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.cpp:
(WebCore::RenderSVGResourceLinearGradient::RenderSVGResourceLinearGradient):
* Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp:
(WebCore::RenderSVGResourceMarker::RenderSVGResourceMarker):
* Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::RenderSVGResourceMasker):
* Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::RenderSVGResourcePattern):
* Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.cpp:
(WebCore::RenderSVGResourceRadialGradient::RenderSVGResourceRadialGradient):
* Source/WebCore/rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::RenderSVGRoot):
* Source/WebCore/rendering/svg/RenderSVGRoot.h:
* Source/WebCore/rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::RenderSVGShape):
* Source/WebCore/rendering/svg/RenderSVGShape.h:
* Source/WebCore/rendering/svg/RenderSVGTSpan.h:
* Source/WebCore/rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::RenderSVGText):
* Source/WebCore/rendering/svg/RenderSVGText.h:
* Source/WebCore/rendering/svg/RenderSVGTextPath.cpp:
(WebCore::RenderSVGTextPath::RenderSVGTextPath):
* Source/WebCore/rendering/svg/RenderSVGTextPath.h:
* Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp:
(WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer):
* Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h:
* Source/WebCore/rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
* Source/WebCore/rendering/svg/RenderSVGViewportContainer.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.cpp:
(WebCore::LegacyRenderSVGContainer::LegacyRenderSVGContainer):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGEllipse.cpp:
(WebCore::LegacyRenderSVGEllipse::LegacyRenderSVGEllipse):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.cpp:
(WebCore::LegacyRenderSVGForeignObject::LegacyRenderSVGForeignObject):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGHiddenContainer.cpp:
(WebCore::LegacyRenderSVGHiddenContainer::LegacyRenderSVGHiddenContainer):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGHiddenContainer.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.cpp:
(WebCore::LegacyRenderSVGImage::LegacyRenderSVGImage):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp:
(WebCore::LegacyRenderSVGModelObject::LegacyRenderSVGModelObject):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.cpp:
(WebCore::LegacyRenderSVGPath::LegacyRenderSVGPath):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRect.cpp:
(WebCore::LegacyRenderSVGRect::LegacyRenderSVGRect):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.cpp:
(WebCore::LegacyRenderSVGResourceClipper::LegacyRenderSVGResourceClipper):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceContainer.cpp:
(WebCore::LegacyRenderSVGResourceContainer::LegacyRenderSVGResourceContainer):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceContainer.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp:
(WebCore::LegacyRenderSVGRoot::LegacyRenderSVGRoot):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp:
(WebCore::LegacyRenderSVGShape::LegacyRenderSVGShape):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGTransformableContainer.cpp:
(WebCore::LegacyRenderSVGTransformableContainer::LegacyRenderSVGTransformableContainer):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGTransformableContainer.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGViewportContainer.cpp:
(WebCore::LegacyRenderSVGViewportContainer::LegacyRenderSVGViewportContainer):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGViewportContainer.h:
* Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp:
(WebCore::RenderTreeBuilder::FirstLetter::updateStyle):
(WebCore::RenderTreeBuilder::FirstLetter::createRenderers):
* Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp:
(WebCore::cloneAsContinuation):
(WebCore::RenderTreeBuilder::Inline::attachIgnoringContinuation):
* Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp:
(WebCore::createAnonymousRubyInlineBlock):
(WebCore::RenderTreeBuilder::Ruby::findOrCreateParentForStyleBasedRubyChild):
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::createTextRenderer):
* Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:
(WebCore::RenderTreeUpdater::GeneratedContent::updateBackdropRenderer):
* Source/WebCore/svg/SVGAElement.cpp:
(WebCore::SVGAElement::createElementRenderer):
* Source/WebCore/svg/SVGDefsElement.cpp:
(WebCore::SVGDefsElement::createElementRenderer):
* Source/WebCore/svg/SVGGElement.cpp:
(WebCore::SVGGElement::createElementRenderer):
* Source/WebCore/svg/SVGSymbolElement.cpp:
(WebCore::SVGSymbolElement::createElementRenderer):
* Source/WebCore/svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::createElementRenderer):

Canonical link: https://commits.webkit.org/268604@main
@webkit-commit-queue
Copy link
Collaborator

Committed 268604@main (7b1df14): https://commits.webkit.org/268604@main

Reviewed commits have been landed. Closing PR #18352 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7b1df14 into WebKit:main Sep 28, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Layout and Rendering For bugs with layout and rendering of Web pages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants