[Temporal] Implement `with` method for PlainMonthDay by catamorphism · Pull Request #52251 · WebKit/WebKit

catamorphism · 2025-10-13T18:29:20Z

`f37c4da`

[Temporal] Implement `with` method for PlainMonthDay

https://bugs.webkit.org/show_bug.cgi?id=300640

Reviewed by Yusuke Suzuki.

with() calls TemporalCalendar::monthDayFromFields(), which calls
TemporalCalendar::isoDateFromFields() -- hence the changes to the type
signature of isoDateFromFields(), which also change the type signatures
of various from() methods.

* JSTests/stress/temporal-plainmonthday.js:
(shouldBe):
* JSTests/test262/config.yaml:
* JSTests/test262/expectations.yaml:
* Source/JavaScriptCore/runtime/ISO8601.cpp:
(JSC::ISO8601::parseMonthCode):
(JSC::ISO8601::validMonthCode):
(JSC::ISO8601::monthFromCode): Deleted.
* Source/JavaScriptCore/runtime/ISO8601.h:
* Source/JavaScriptCore/runtime/TemporalCalendar.cpp:
(JSC::calendarResolveFields):
(JSC::TemporalCalendar::isoDateFromFields):
(JSC::TemporalCalendar::monthDayFromFields):
* Source/JavaScriptCore/runtime/TemporalCalendar.h:
* Source/JavaScriptCore/runtime/TemporalCalendarPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/TemporalDuration.cpp:
(JSC::getEpochNanosecondsFor):
* Source/JavaScriptCore/runtime/TemporalDuration.h:
* Source/JavaScriptCore/runtime/TemporalObject.cpp:
(JSC::getMonthCode):
* Source/JavaScriptCore/runtime/TemporalObject.h:
* Source/JavaScriptCore/runtime/TemporalPlainDate.cpp:
(JSC::TemporalPlainDate::from):
(JSC::TemporalPlainDate::toPartialDate):
(JSC::TemporalPlainDate::with):
* Source/JavaScriptCore/runtime/TemporalPlainDate.h:
* Source/JavaScriptCore/runtime/TemporalPlainDateConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/TemporalPlainDatePrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/TemporalPlainDateTime.cpp:
(JSC::TemporalPlainDateTime::from):
(JSC::TemporalPlainDateTime::with):
* Source/JavaScriptCore/runtime/TemporalPlainDateTime.h:
* Source/JavaScriptCore/runtime/TemporalPlainDateTimeConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/TemporalPlainMonthDay.cpp:
(JSC::TemporalPlainMonthDay::with):
* Source/JavaScriptCore/runtime/TemporalPlainMonthDay.h:
* Source/JavaScriptCore/runtime/TemporalPlainMonthDayConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/TemporalPlainMonthDayPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSC_DEFINE_CUSTOM_GETTER):

Canonical link: https://commits.webkit.org/303360@main

dce8c5b

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	~~🧪 api-mac-debug~~	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	~~🧪 mac-AS-debug-wk2~~	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-wk2-stress	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🛠 mac-safer-cpp	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-10-13T18:29:28Z

EWS run on previous version of this PR (hash 3c6140e)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 win
	⏳ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🧪 api-mac	⏳ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	⏳ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	⏳ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	⏳ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	⏳ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	⏳ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	⏳ 🛠 playstation
	⏳ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	⏳ 🛠 tv-sim		~~🧪 jsc-armv7-tests~~
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

Source/JavaScriptCore/runtime/ISO8601.cpp

Source/JavaScriptCore/runtime/ISO8601.h

Source/JavaScriptCore/runtime/TemporalCalendar.cpp

Source/JavaScriptCore/runtime/TemporalObject.cpp

webkit-early-warning-system · 2025-10-13T19:25:31Z

EWS run on previous version of this PR (hash 724fd55)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

Constellation

Overall, I'm very concerning about these double year / month / day.
It is very inefficient.
Can you provide what part of the spec makes it double instead of using integers?

catamorphism · 2025-10-14T18:42:36Z

Overall, I'm very concerning about these double year / month / day. It is very inefficient. Can you provide what part of the spec makes it double instead of using integers?

@Constellation In the spec, Calendar Fields Records ( https://tc39.es/proposal-temporal/#sec-temporal-calendar-fields-records ) have integer fields; these are mathematical integers and not 32-bit integers.

In the code, isoDateFromFields (the overload that takes a JSObject* as the second argument) gets the year, month and day values directly from the JSObject, by calling toIntegerOrInfinity(), which returns a double. These double values are eventually converted to either int32_t or unsigned when the PlainDate (or PlainMonthDay, etc.) constructor is called, but I don't see a drawback to re-using these values so we can follow the spec in terms of exactly when validation is performed. No calculations are done on these double values; they're just passed around.

I can move the validation earlier if absolutely necessary, so that the doubles returned by toIntegerOrInfinity() are converted earlier, but I'm concerned about potential code duplication, potentially breaking tests that rely on checks being performed in a particular order, and departing (further) from the spec.

webkit-early-warning-system · 2025-10-18T21:09:30Z

EWS run on previous version of this PR (hash 68c64c7)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	~~🛠 wpe~~	❌ 🛠 win
	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	❌ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	~~🧪 api-wpe~~
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🛠 wpe-cairo
❌ 🛠 🧪 jsc	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🛠 gtk
❌ 🛠 🧪 jsc-arm64	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	❌ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	⏳ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	⏳ 🛠 playstation
	❌ 🛠 tv	❌ 🛠 mac-safer-cpp	❌ 🛠 jsc-armv7
	❌ 🛠 tv-sim		❌ 🧪 jsc-armv7-tests
	❌ 🛠 watch
	❌ 🛠 watch-sim

catamorphism · 2025-10-18T21:11:01Z

@Constellation In 68c64c7 I changed the functions in questions to take int32_t / unsigned instead of double for year/month/day values. There's some code duplication, but not as much as I had thought there would be. Please take a look when you get a chance.

webkit-early-warning-system · 2025-10-18T21:51:24Z

EWS run on previous version of this PR (hash 89e2078)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

Constellation

Commented. Please check all error cases are annotated as [[unlikely]] and checking whether there is missing error cases.

Source/JavaScriptCore/runtime/TemporalCalendar.cpp

Source/JavaScriptCore/runtime/TemporalPlainMonthDay.cpp

Source/JavaScriptCore/runtime/TemporalPlainMonthDayPrototype.cpp

Source/JavaScriptCore/runtime/TemporalPlainDate.cpp

Source/JavaScriptCore/runtime/TemporalCalendar.cpp

webkit-early-warning-system · 2025-10-27T17:14:28Z

EWS run on previous version of this PR (hash 348c785)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	⏳ 🛠 wpe-cairo
~~🛠 🧪 jsc~~	~~🧪 api-ios~~	~~🧪 mac-wk2~~	⏳ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	⏳ 🧪 gtk-wk2
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	⏳ 🧪 api-gtk
	~~🧪 vision-wk2~~	~~🧪 mac-intel-wk2~~	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		~~🧪 jsc-armv7-tests~~
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2025-10-27T17:17:51Z

EWS run on previous version of this PR (hash 3c4d9d5)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-11-14T01:49:50Z

EWS run on previous version of this PR (hash 88d508b)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	⏳ 🧪 api-mac-debug	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-wk2-stress	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🛠 mac-safer-cpp	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-11-20T20:17:32Z

EWS run on current version of this PR (hash dce8c5b)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	~~🧪 api-mac-debug~~	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	~~🧪 mac-AS-debug-wk2~~	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-wk2-stress	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🛠 mac-safer-cpp	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

catamorphism · 2025-11-20T20:17:59Z

Squashed and rebased.

https://bugs.webkit.org/show_bug.cgi?id=300640 Reviewed by Yusuke Suzuki. with() calls TemporalCalendar::monthDayFromFields(), which calls TemporalCalendar::isoDateFromFields() -- hence the changes to the type signature of isoDateFromFields(), which also change the type signatures of various from() methods. * JSTests/stress/temporal-plainmonthday.js: (shouldBe): * JSTests/test262/config.yaml: * JSTests/test262/expectations.yaml: * Source/JavaScriptCore/runtime/ISO8601.cpp: (JSC::ISO8601::parseMonthCode): (JSC::ISO8601::validMonthCode): (JSC::ISO8601::monthFromCode): Deleted. * Source/JavaScriptCore/runtime/ISO8601.h: * Source/JavaScriptCore/runtime/TemporalCalendar.cpp: (JSC::calendarResolveFields): (JSC::TemporalCalendar::isoDateFromFields): (JSC::TemporalCalendar::monthDayFromFields): * Source/JavaScriptCore/runtime/TemporalCalendar.h: * Source/JavaScriptCore/runtime/TemporalCalendarPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/TemporalDuration.cpp: (JSC::getEpochNanosecondsFor): * Source/JavaScriptCore/runtime/TemporalDuration.h: * Source/JavaScriptCore/runtime/TemporalObject.cpp: (JSC::getMonthCode): * Source/JavaScriptCore/runtime/TemporalObject.h: * Source/JavaScriptCore/runtime/TemporalPlainDate.cpp: (JSC::TemporalPlainDate::from): (JSC::TemporalPlainDate::toPartialDate): (JSC::TemporalPlainDate::with): * Source/JavaScriptCore/runtime/TemporalPlainDate.h: * Source/JavaScriptCore/runtime/TemporalPlainDateConstructor.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/TemporalPlainDatePrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/TemporalPlainDateTime.cpp: (JSC::TemporalPlainDateTime::from): (JSC::TemporalPlainDateTime::with): * Source/JavaScriptCore/runtime/TemporalPlainDateTime.h: * Source/JavaScriptCore/runtime/TemporalPlainDateTimeConstructor.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/TemporalPlainMonthDay.cpp: (JSC::TemporalPlainMonthDay::with): * Source/JavaScriptCore/runtime/TemporalPlainMonthDay.h: * Source/JavaScriptCore/runtime/TemporalPlainMonthDayConstructor.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/TemporalPlainMonthDayPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): (JSC::JSC_DEFINE_CUSTOM_GETTER): Canonical link: https://commits.webkit.org/303360@main

webkit-commit-queue · 2025-11-20T23:53:49Z

Committed 303360@main (f37c4da): https://commits.webkit.org/303360@main

Reviewed commits have been landed. Closing PR #52251 and removing active labels.

catamorphism requested a review from a team as a code owner October 13, 2025 18:29

catamorphism self-assigned this Oct 13, 2025

catamorphism added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Oct 13, 2025

Constellation requested changes Oct 13, 2025

View reviewed changes

Constellation requested changes Oct 14, 2025

View reviewed changes

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 18, 2025

catamorphism force-pushed the plainmonthday-plainyearmonth-part-4 branch from 68c64c7 to 89e2078 Compare October 18, 2025 21:51

Constellation reviewed Oct 23, 2025

View reviewed changes

catamorphism force-pushed the plainmonthday-plainyearmonth-part-4 branch from 3c4d9d5 to 88d508b Compare November 14, 2025 01:49

Constellation approved these changes Nov 20, 2025

View reviewed changes

catamorphism force-pushed the plainmonthday-plainyearmonth-part-4 branch from 88d508b to dce8c5b Compare November 20, 2025 20:17

catamorphism added request-merge-queue Request a pull request to be added to merge-queue once ready and removed merging-blocked Applied to prevent a change from being merged labels Nov 20, 2025

ptomato added merge-queue Applied to send a pull request to merge-queue and removed request-merge-queue Request a pull request to be added to merge-queue once ready labels Nov 20, 2025

webkit-commit-queue force-pushed the plainmonthday-plainyearmonth-part-4 branch from dce8c5b to f37c4da Compare November 20, 2025 23:53

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 20, 2025

webkit-commit-queue merged commit f37c4da into WebKit:main Nov 20, 2025

Conversation

catamorphism commented Oct 13, 2025 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

f37c4da

Uh oh!

webkit-early-warning-system commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Constellation left a comment

Choose a reason for hiding this comment

Uh oh!

catamorphism commented Oct 14, 2025

Uh oh!

webkit-early-warning-system commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

catamorphism commented Oct 18, 2025

Uh oh!

webkit-early-warning-system commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Constellation left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

catamorphism commented Nov 20, 2025

Uh oh!

webkit-commit-queue commented Nov 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

catamorphism commented Oct 13, 2025 •

edited by webkit-early-warning-system

Loading

`f37c4da`

webkit-early-warning-system commented Oct 13, 2025 •

edited

Loading

webkit-early-warning-system commented Oct 13, 2025 •

edited

Loading

webkit-early-warning-system commented Oct 18, 2025 •

edited

Loading

webkit-early-warning-system commented Oct 18, 2025 •

edited

Loading

webkit-early-warning-system commented Oct 27, 2025 •

edited

Loading

webkit-early-warning-system commented Oct 27, 2025 •

edited

Loading

webkit-early-warning-system commented Nov 14, 2025 •

edited

Loading

webkit-early-warning-system commented Nov 20, 2025 •

edited

Loading