[WPE] Right mouse button click stops further mouse button processing#54398
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Nov 25, 2025
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 249a92e) Details |
Contributor
|
Been running this patch (with a little extra) for several months now (chrisduerr@33926f4) and can definitely confirm it fixes https://bugs.webkit.org/show_bug.cgi?id=272354#c7 for me. |
kate-k-lee
force-pushed
the
eng/WPE-Right-mouse-button-click-stops-further-mouse-button-processing
branch
from
249a92e to
1a7c5b0
Compare
Collaborator
|
EWS run on current version of this PR (hash 1a7c5b0) Details |
kate-k-lee
changed the title
Contributor
Author
|
@chrisduerr Thanks a lot for confirming, and also for the initial work you did on this issue. Thanks again for laying the groundwork! |
aperezdc
approved these changes
Nov 24, 2025
fujii
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=272354 Reviewed by Adrian Perez de Castro. The context menu request was not followed by any implementation logic. As a result, WebPageProxy:: clearWaitingForContextMenuToShow() was never called, leaving the page stuck in a state where mouse click events were not processed. This patch introduces the initial plumbing for WPE context menu handling. Follow-up patches will impl- ement the full public API to expose hit-test results and context-menu item information to the application. This patch is based on the original work by chrisduerr@. I have updated the work for the WPE port. Co-authored-by: Christian Duerr(chrisduerr@)<[email protected]> * Source/WebKit/SourcesWPE.txt: * Source/WebKit/UIProcess/wpe/WebContextMenuProxyWPE.cpp: Copied from Source/WebKit/UIProcess/wpe/WebContextMenuProxyWPE.h. (WebKit::WebContextMenuProxyWPE::WebContextMenuProxyWPE): (WebKit::WebContextMenuProxyWPE::showContextMenuWithItems): * Source/WebKit/UIProcess/wpe/WebContextMenuProxyWPE.h: Canonical link: https://commits.webkit.org/303518@main
webkit-commit-queue
changed the title
webkit-commit-queue
force-pushed
the
eng/WPE-Right-mouse-button-click-stops-further-mouse-button-processing
branch
from
1a7c5b0 to
d811b27
Compare
Collaborator
|
Committed 303518@main (d811b27): https://commits.webkit.org/303518@main Reviewed commits have been landed. Closing PR #54398 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
aperezdc
added
the
GLib Suggested Backport - 2.50
Contributor
|
Backported into |
aperezdc
removed
the
GLib Suggested Backport - 2.50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d811b27
1a7c5b0
🧪 ios-wk2🧪 ios-wk2-wpt🧪 api-ios🛠 playstation