Skip to content

[WPE] Implement damage propagation in non-composited mode#55697

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Scony:304482-graphics-wpe-compositorless-damage
Jan 13, 2026
Merged

[WPE] Implement damage propagation in non-composited mode#55697
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Scony:304482-graphics-wpe-compositorless-damage

Conversation

@Scony
Copy link
Contributor

@Scony Scony commented Dec 19, 2025 •
edited by webkit-early-warning-system
Loading

816db04

[WPE] Implement damage propagation in non-composited mode
https://bugs.webkit.org/show_bug.cgi?id=304482

Reviewed by Carlos Garcia Campos.

This change implements damage propagation in the non-composited page
rendering mode.

With this change, depending on the run time preferences, the damage
information is:
- not propagated at all,
- propagated to the platform only,
- propagated and used to reduce the amount of painting done to render
  target.

This change also adds a test case for the above and does a small
rename (frameDamageSinceLastUse() -> renderTargetDamage()) in the
accelerated surface to better reflect the reality.

Canonical link: https://commits.webkit.org/305510@main

3d5929d

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ❌ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@Scony Scony requested a review from magomez as a code owner December 19, 2025 10:02
@Scony Scony self-assigned this Dec 19, 2025
@Scony Scony added the WPE WebKit WebKit WPE component label Dec 19, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 19, 2025 •
edited
Loading

EWS run on previous version of this PR (hash ec016bb)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 win
❌ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
❌ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 19, 2025
@Scony Scony removed the merging-blocked Applied to prevent a change from being merged label Jan 5, 2026
@Scony Scony force-pushed the 304482-graphics-wpe-compositorless-damage branch from ec016bb to db0b233 Compare January 5, 2026 13:27
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 5, 2026 •
edited
Loading

EWS run on previous version of this PR (hash db0b233)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@Scony Scony force-pushed the 304482-graphics-wpe-compositorless-damage branch from db0b233 to 3d5929d Compare January 13, 2026 08:34
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 13, 2026 •
edited
Loading

EWS run on current version of this PR (hash 3d5929d)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ❌ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 13, 2026
@Scony Scony added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Jan 13, 2026
@Scony
[WPE] Implement damage propagation in non-composited mode
816db04 
https://bugs.webkit.org/show_bug.cgi?id=304482

Reviewed by Carlos Garcia Campos.

This change implements damage propagation in the non-composited page
rendering mode.

With this change, depending on the run time preferences, the damage
information is:
- not propagated at all,
- propagated to the platform only,
- propagated and used to reduce the amount of painting done to render
  target.

This change also adds a test case for the above and does a small
rename (frameDamageSinceLastUse() -> renderTargetDamage()) in the
accelerated surface to better reflect the reality.

Canonical link: https://commits.webkit.org/305510@main
@webkit-commit-queue webkit-commit-queue force-pushed the 304482-graphics-wpe-compositorless-damage branch from 3d5929d to 816db04 Compare January 13, 2026 13:34
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Jan 13, 2026

Committed 305510@main (816db04): https://commits.webkit.org/305510@main

Reviewed commits have been landed. Closing PR #55697 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 816db04 into WebKit:main Jan 13, 2026
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spenap spenap spenap left review comments

@carlosgcampos carlosgcampos carlosgcampos approved these changes

@magomez magomez Awaiting requested review from magomez magomez is a code owner

Assignees

@Scony Scony

Labels

WPE WebKit WebKit WPE component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Scony @webkit-early-warning-system @webkit-commit-queue @spenap @carlosgcampos @webkit-ews-buildbot