Merged
Conversation
Function definitions without an argument list are disallowed in C23. Removed dropped arguments in later call to function.
Next-Door-Tech
force-pushed
the
small-fixes
branch
from
1294d34 to
b243be7
Compare
mstroh76
approved these changes
Jun 8, 2025
Next-Door-Tech
commented
Jun 8, 2025
Comment on lines
-3363
to
+3362
| GetRP1Memory(pciemem_RP1, sizeof(pciemem_RP1)); | ||
| GetRP1Memory(); |
Contributor
Author
There was a problem hiding this comment.
Requesting review from @mstroh76
These arguments were just being ignored, correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a couple small fixes.
calloc(count, size)void GetRP1Memory()was defined without an argument list, which is deprecated in C23. Definition re