Issue #378 - Have wiringPiISR and wiringPiISR2 return error on failure in initialization#379
Merged
mstroh76 merged 3 commits intoWiringPi:wiringPiISRfrom Aug 26, 2025
Merged
Conversation
…zation The each function initializes the event listener loop in a spawned listener thread. The new thread does not report errors back to the original caller. So the function misses initialization errors. The code is fixed to initialize the event listener in the original thread before spawning the listener thread so that the function can pick up errors and return them to the user.
mstroh76
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix to functions wiringPiISR and wiringpiISR2 for issue #378.
The each function initializes the event listener loop in a spawned
listener thread. The new thread does not report errors back to the
original caller. So the function misses the initialization errors.
The code is fixed to initialize the event listener in the original
thread before spawning the listener thread so that the function
can pick up errors and return them to the user.
Tested using Raspberry Pi 4. The following attached file is the test code.
wpi-test.tar.gz