Mention about output format in the README#236
Closed
midnight-wonderer wants to merge 1 commit intoWorksApplications:developfrom
Closed
Mention about output format in the README#236midnight-wonderer wants to merge 1 commit intoWorksApplications:developfrom
midnight-wonderer wants to merge 1 commit intoWorksApplications:developfrom
Conversation
mh-northlander
suggested changes
Oct 15, 2024
Contributor
There was a problem hiding this comment.
Thank you for pointing out that the readme is not updated.
Since the SimpleMorphemeFormatter class defines the default behavior of the Sudachi CLI tool, I would rather want to update line 74 (and l.409) instead.
Now with the -a option, Sudachi additionally prints: the dictionary form, the reading form, the dictionary id, list of synonym group ids and OOV flag if it is so.
Contributor
|
Close this and update readme in another PR. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there,
I tried Sudachi with
-a; the problem is that the output has a weird number at the end for some inputs.Like this:
It would be better if you mentioned something to help out new users in the README. Especially for users who are just Japanese learners.
I understand it is complicated with option flags and plugins. However, there should be a link to the relevant code so that people can understand it better.