Merged
Conversation
MattKiazyk
approved these changes
Dec 17, 2021
Contributor
|
@fishcharlie 🙏 🙏 As far as I can tell this is working as advertised! We'll find out for sure next release, but I'll for sure double check on an M1 (now that I have one) and the old intel one |
Contributor
|
Worked great for me on my M1, installed via the $ file /usr/local/bin/xcodes
/usr/local/bin/xcodes: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64]
/usr/local/bin/xcodes (for architecture x86_64): Mach-O 64-bit executable x86_64
/usr/local/bin/xcodes (for architecture arm64): Mach-O 64-bit executable arm64 |
Contributor
|
👍 - it doubled the zip from 1.8 to 3.6 MB 😄 |
Contributor
|
By law, no one is allowed to complain about 3.6MB for a tool used to download 10+ GB files from the internet 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #170
@MattKiazyk Might want to test this before merging. It looks like maybe the output executable might be in a different location. But since I'm not completely familiar with the build/distribution system of this project, I'm not sure that matters.
I was able to verify that the outputted executable from this PR does produce a universal binary tho.
Please let me know if any adjustments need to be made.