Exit immediately if trying to select currently selected xcode#181
Merged
MattKiazyk merged 3 commits intoXcodesOrg:mainfrom Sep 29, 2022
Merged
Exit immediately if trying to select currently selected xcode#181MattKiazyk merged 3 commits intoXcodesOrg:mainfrom
MattKiazyk merged 3 commits intoXcodesOrg:mainfrom
Conversation
tahirmt
force-pushed
the
select-current-exit-immediately
branch
2 times, most recently
from
91e3655 to
eb8e698
Compare
tahirmt
force-pushed
the
select-current-exit-immediately
branch
2 times, most recently
from
c3712ce to
fbe2b25
Compare
rogerluan
approved these changes
Sep 19, 2022
Contributor
rogerluan
left a comment
rogerluan
left a comment
There was a problem hiding this comment.
LGTM, just 2 nitpicks :)
tahirmt
commented
Sep 19, 2022
If the currently requested xcode is already selected, there is no need to prompt the user to give sudo permissions and re-select the path. We can just avoid the step and exit early.
Co-authored-by: Roger Oba <[email protected]>
tahirmt
force-pushed
the
select-current-exit-immediately
branch
from
0b43aee to
030ac5f
Compare
Contributor
|
@MattKiazyk just a heads up that this PR could/should be merged before #182 🤗 #182 branched off of this one :) |
MattKiazyk
approved these changes
Sep 29, 2022
Contributor
MattKiazyk
left a comment
MattKiazyk
left a comment
There was a problem hiding this comment.
Thanks @tahirmt sorry for the delayed approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the currently requested xcode is already selected, there is no need to prompt the user to give sudo permissions and re-select the path. We can just avoid the step and exit early.
Closes #102