Skip to content

Add user password history entity.#23894

Merged
hikalkan merged 19 commits intodevfrom
PasswordHistory
Oct 14, 2025
Merged

Add user password history entity.#23894
hikalkan merged 19 commits intodevfrom
PasswordHistory

Conversation

@maliming
Copy link
Member

@maliming maliming commented Oct 7, 2025

No description provided.

@maliming maliming added this to the 10.1-preview milestone Oct 7, 2025
@maliming maliming requested a review from Copilot October 8, 2025 02:38
@maliming maliming marked this pull request as ready for review October 8, 2025 02:38
Copilot AI reviewed Oct 8, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a user password history entity to the ABP Identity module to support password reuse prevention functionality.

Key changes:

  • Introduces IdentityUserPasswordHistory entity to track user password history
  • Adds settings to configure password reuse prevention (enable/disable and count of previous passwords to check)
  • Updates Entity Framework and MongoDB contexts to support the new entity

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
IAbpIdentityMongoDbContext.cs Adds MongoDB collection property for password histories
AbpIdentityMongoDbContext.cs Implements MongoDB collection for password histories
IdentityEfCoreQueryableExtensions.cs Includes password histories in user detail queries
IdentityDbContextModelBuilderExtensions.cs Configures Entity Framework mapping for password history entity
IdentityUserPasswordHistory.cs Defines the password history entity with user ID and password as composite key
IdentityUser.cs Adds password history navigation property and helper method
AbpIdentitySettingDefinitionProvider.cs Adds settings for password reuse prevention configuration
AbpIdentityResultExtensions.cs Adds localization string for password reuse error message
IdentitySettingNames.cs Defines setting names for password reuse prevention
en.json Adds English localization for password reuse error message
IdentityUserPasswordHistoriesConsts.cs Defines constants for password history entity

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

maliming and others added 2 commits October 8, 2025 10:43
@maliming
Update modules/identity/src/Volo.Abp.Identity.Domain/Volo/Abp/Identit…
7a2bc0d 
…y/IdentityUserPasswordHistory.cs

Co-authored-by: Copilot <[email protected]>
@maliming
Update modules/identity/src/Volo.Abp.Identity.Domain/Volo/Abp/Identit…
66ab43b 
…y/IdentityUserPasswordHistory.cs

Co-authored-by: Copilot <[email protected]>
Copilot AI and others added 3 commits October 8, 2025 02:48
Initial plan
a2c5e1e
@maliming
Add PasswordInHistory localization to all language files
4317bac 
Co-authored-by: maliming <[email protected]>
@maliming
Merge pull request #23907 from abpframework/copilot/add-password-hist…
9673e0a 
…ory-localization

Add PasswordInHistory localization text to all language files
@CLAassistant
Copy link

CLAassistant commented Oct 8, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ maliming
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

@maliming maliming marked this pull request as draft October 8, 2025 03:41
@maliming maliming marked this pull request as ready for review October 8, 2025 08:07
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 53.22581% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.09%. Comparing base (2750b3a) to head (7d63a83).
⚠️ Report is 64 commits behind head on dev.

Files with missing lines Patch % Lines
...n/Volo/Abp/Identity/IdentityUserPasswordHistory.cs 0.00% 21 Missing ⚠️
....Identity.Domain/Volo/Abp/Identity/IdentityUser.cs 22.22% 7 Missing ⚠️
.../Abp/Identity/MongoDB/AbpIdentityMongoDbContext.cs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              dev   #23894   +/-   ##
=======================================
  Coverage   51.09%   51.09%           
=======================================
  Files        3269     3271    +2     
  Lines      106432   106500   +68     
  Branches     8173     8174    +1     
=======================================
+ Hits        54379    54420   +41     
- Misses      50379    50406   +27     
  Partials     1674     1674

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maliming maliming requested a review from hikalkan October 9, 2025 06:22
@maliming maliming requested a review from EngincanV October 9, 2025 06:22
@hikalkan hikalkan merged commit ed87b05 into dev Oct 14, 2025
1 of 3 checks passed
@hikalkan hikalkan deleted the PasswordHistory branch October 14, 2025 09:27
@hikalkan
Copy link
Member

hikalkan commented Oct 14, 2025

I marked as breaking change since it requires database migration. Please note that in the migration guide.

@enisn enisn mentioned this pull request Feb 23, 2026
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@hikalkan hikalkan hikalkan approved these changes

@EngincanV EngincanV EngincanV approved these changes

Assignees

Copilot code review Copilot

Labels

abp-module-identity breaking change

Projects

None yet

Milestone

10.1-preview

Development

Successfully merging this pull request may close these issues.

6 participants

@maliming @CLAassistant @hikalkan @EngincanV