Remove AsyncKeyedLock dependency from LocalAbpDistributedLock.#24425
Merged
Remove AsyncKeyedLock dependency from LocalAbpDistributedLock.#24425
AsyncKeyedLock dependency from LocalAbpDistributedLock.#24425Conversation
Contributor
|
What's the motivation here, just dropping the dependency? This version of the code has a memory leak. For every distinct key that gets used, a SemaphoreSlim object remains permanently in memory. AsyncKeyedLock is battle-tested and has been used in ABP for years without issues. |
EngincanV
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.