Refactor token validation in CookieAuthenticationOptionsExtensions#24526
Merged
Refactor token validation in CookieAuthenticationOptionsExtensions#24526
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors token validation in the CookieAuthenticationOptionsExtensions to improve maintainability, fix logic errors, and consolidate duplicate code. The changes resolve issue #24468 by fixing the token expiration check logic and improving the handling of introspection endpoints.
Key Changes:
- Fixed token expiration check logic to properly validate tokens expiring within the advance window (changed from checking expired tokens to checking soon-to-expire tokens)
- Added support for chaining multiple
OnValidatePrincipalhandlers by preserving and invoking the previous handler - Consolidated duplicate code by marking
IntrospectAccessTokenas obsolete and delegating toCheckTokenExpiration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
framework/src/Volo.Abp.AspNetCore/Microsoft/Extensions/DependencyInjection/CookieAuthenticationOptionsExtensions.cs |
Core refactoring with bug fixes: corrected token expiration logic, improved introspection endpoint handling with fallback logic, enhanced logging messages with structured parameters, fixed async method modifiers, and added previousHandler chaining support |
framework/src/Volo.Abp.AspNetCore.Components.Server/Microsoft/AspNetCore/Authentication/Cookies/CookieAuthenticationOptionsExtensions.cs |
Simplified by removing duplicate implementation and delegating to the main CheckTokenExpiration method, marked old method as obsolete |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...AspNetCore/Microsoft/Extensions/DependencyInjection/CookieAuthenticationOptionsExtensions.cs
Show resolved
Hide resolved
...AspNetCore/Microsoft/Extensions/DependencyInjection/CookieAuthenticationOptionsExtensions.cs
Show resolved
Hide resolved
....Server/Microsoft/AspNetCore/Authentication/Cookies/CookieAuthenticationOptionsExtensions.cs
Show resolved
Hide resolved
EngincanV
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #24468