Add 'no records to export' localization key#24557
Merged
Conversation
maliming
requested review from
Copilot,
salihozkara and
yagmurcelk
and removed request for
Copilot
salihozkara
reviewed
Jan 6, 2026
...t-logging/src/Volo.Abp.AuditLogging.Domain.Shared/Volo/Abp/AuditLogging/Localization/tr.json
Outdated
Show resolved
Hide resolved
…Volo/Abp/AuditLogging/Localization/tr.json Co-authored-by: SALİH ÖZKARA <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new localization key "ThereWereNoRecordsToExport" to provide user-facing messages when there are no records available for export in the audit logging module. The key is added consistently across 18 language files with appropriate translations.
- Adds "ThereWereNoRecordsToExport" localization key across multiple language files
- Positions the new key consistently after "ExportFailed" in all files
- Provides translations in 18 languages including English, Chinese (Traditional/Simplified), Turkish, Swedish, Slovenian, Slovak, Russian, Portuguese (BR), Polish, Dutch, Hungarian, French, Finnish, Spanish, German, Czech, and Arabic
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| en.json | Adds English base translation: "There were no records to export." |
| zh-Hant.json | Adds Traditional Chinese translation |
| zh-Hans.json | Adds Simplified Chinese translation |
| tr.json | Adds Turkish translation |
| sv.json | Adds Swedish translation |
| sl.json | Adds Slovenian translation |
| sk.json | Adds Slovak translation |
| ru.json | Adds Russian translation |
| pt-BR.json | Adds Brazilian Portuguese translation |
| pl-PL.json | Adds Polish translation |
| nl.json | Adds Dutch translation |
| hu.json | Adds Hungarian translation |
| fr.json | Adds French translation |
| fi.json | Adds Finnish translation |
| es.json | Adds Spanish translation |
| de.json | Adds German translation |
| cs.json | Adds Czech translation |
| ar.json | Adds Arabic translation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "Exporting": "Exporting", | ||
| "ExportCompleted": "Export completed successfully", | ||
| "ExportFailed": "Export failed", | ||
| "ThereWereNoRecordsToExport": "There were no records to export.", |
There was a problem hiding this comment.
The Italian localization file (it.json) contains export-related keys including "ExportFailed" but is missing the new "ThereWereNoRecordsToExport" key. For consistency, this file should also receive the new localization key.
salihozkara
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.