Refactor dynamic initializers to use service provider#24571
Merged
Refactor dynamic initializers to use service provider#24571
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors three dynamic initializers (SettingDynamicInitializer, PermissionDynamicInitializer, and FeatureDynamicInitializer) to use a service locator pattern instead of constructor injection. The changes simplify the constructors by injecting only IServiceProvider, and then resolving dependencies on-demand when they are needed.
- Simplified constructors to accept only IServiceProvider instead of multiple dependencies
- Changed from field-based dependency injection to on-demand service resolution using GetRequiredService/GetService
- Removed unused JetBrains.Annotations import and [CanBeNull] attributes
- Improved code formatting with multi-line parameter lists
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| SettingDynamicInitializer.cs | Refactored to use service locator pattern, resolving IOptions, IHostApplicationLifetime, ICancellationTokenProvider, IStaticSettingSaver, and IDynamicSettingDefinitionStore on-demand |
| PermissionDynamicInitializer.cs | Refactored to use service locator pattern, resolving IOptions, IHostApplicationLifetime, ICancellationTokenProvider, IStaticPermissionSaver, and IDynamicPermissionDefinitionStore on-demand |
| FeatureDynamicInitializer.cs | Refactored to use service locator pattern, resolving IOptions, IHostApplicationLifetime, ICancellationTokenProvider, IStaticFeatureSaver, and IDynamicFeatureDefinitionStore on-demand |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...rc/Volo.Abp.FeatureManagement.Domain/Volo/Abp/FeatureManagement/FeatureDynamicInitializer.cs
Show resolved
Hide resolved
...rc/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/SettingDynamicInitializer.cs
Show resolved
Hide resolved
...bp.PermissionManagement.Domain/Volo/Abp/PermissionManagement/PermissionDynamicInitializer.cs
Show resolved
Hide resolved
salihozkara
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #24570