Replace LazyLocalizationPipe with AsyncLocalizationPipe#24577
Merged
sumeyyeKurtulus merged 3 commits intorel-10.1from Jan 9, 2026
Merged
Replace LazyLocalizationPipe with AsyncLocalizationPipe#24577sumeyyeKurtulus merged 3 commits intorel-10.1from
sumeyyeKurtulus merged 3 commits intorel-10.1from
Conversation
Updated the routes component to use AsyncLocalizationPipe instead of LazyLocalizationPipe for route name localization. Adjusted template bindings to use the new pipe, improving consistency and potentially performance.
| <i [ngClass]="route.iconClass"></i> | ||
| } | ||
| {{ route.name | abpLazyLocalization | async }} | ||
| {{ route.name | abpAsyncLocalization }} |
Contributor
There was a problem hiding this comment.
As this pipe returns an observable, we need to keep the async pipe here. We should also update the other repositories in the same way.
Appends the async pipe to the abpAsyncLocalization usage in routes.component.html to ensure localized route names are properly resolved from observables.
sumeyyeKurtulus
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the routes component to use AsyncLocalizationPipe instead of LazyLocalizationPipe for route name localization. Adjusted template bindings to use the new pipe, improving consistency and potentially performance.
Description
Resolves #22901 (write the related issue number if available)