Enhance TimeZoneHelper with offset and validation#24607
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a TimeZoneNotFoundException issue on Linux by adding validation and filtering to the TimeZoneHelper.GetTimezones method. The enhancement introduces a new TryCreateNameValueWithOffset method that safely handles invalid timezone identifiers and filters them out instead of throwing exceptions.
Changes:
- Added
TryCreateNameValueWithOffsetmethod to safely create timezone NameValue objects with offset formatting - Refactored
GetTimezonesto filter out invalid timezone IDs using the new method - Upgraded TimeZoneConverter package from 7.0.0 to 7.2.0
- Added comprehensive unit tests for the new functionality
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| framework/src/Volo.Abp.Timing/Volo/Abp/Timing/TimeZoneHelper.cs | Refactored GetTimezones to filter invalid timezones, added TryCreateNameValueWithOffset method, and enhanced XML documentation |
| framework/test/Volo.Abp.Timing.Tests/Volo/Abp/Timing/TimeZoneHelper_Tests.cs | Added new test file with tests for filtering invalid timezones and null return behavior |
| Directory.Packages.props | Updated TimeZoneConverter package version from 7.0.0 to 7.2.0 |
framework/test/Volo.Abp.Timing.Tests/Volo/Abp/Timing/TimeZoneHelper_Tests.cs
Outdated
Show resolved
Hide resolved
framework/test/Volo.Abp.Timing.Tests/Volo/Abp/Timing/TimeZoneHelper_Tests.cs
Show resolved
Hide resolved
framework/src/Volo.Abp.Timing/Volo/Abp/Timing/TimeZoneHelper.cs
Outdated
Show resolved
Hide resolved
framework/src/Volo.Abp.Timing/Volo/Abp/Timing/TimeZoneHelper.cs
Outdated
Show resolved
Hide resolved
framework/src/Volo.Abp.Timing/Volo/Abp/Timing/TimeZoneHelper.cs
Outdated
Show resolved
Hide resolved
framework/test/Volo.Abp.Timing.Tests/Volo/Abp/Timing/TimeZoneHelper_Tests.cs
Outdated
Show resolved
Hide resolved
…elper_Tests.cs Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
framework/src/Volo.Abp.Timing/Volo/Abp/Timing/TimeZoneHelper.cs
Outdated
Show resolved
Hide resolved
framework/test/Volo.Abp.Timing.Tests/Volo/Abp/Timing/TimeZoneHelper_Tests.cs
Outdated
Show resolved
Hide resolved
…elper_Tests.cs Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Catch general exceptions in TimeZoneHelper to handle unexpected errors.
EngincanV
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://abp.io/support/questions/10295/TimeZoneHelperGetTimezones-throws-TimeZoneNotFoundException-on-Linux