Cache ShouldAddComponentAsync result in SimplePageToolbarContributor.#24609
Merged
Cache ShouldAddComponentAsync result in SimplePageToolbarContributor.#24609
ShouldAddComponentAsync result in SimplePageToolbarContributor.#24609Conversation
maliming
changed the title
ShouldAddComponentAsync result in toolbar contributorShouldAddComponentAsync result in SimplePageToolbarContributor.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds caching to the SimplePageToolbarContributor class in the Blazor theming framework to optimize performance by avoiding redundant permission checks. According to the description, the contributor instance is recreated on page refresh, making instance-level caching appropriate for reducing repeated authorization service calls.
Changes:
- Added a private nullable boolean field
_shouldAddComponentto cache the authorization check result - Refactored
ShouldAddComponentAsyncto check the cache first and return early if available, otherwise perform the authorization check and cache the result
.../src/Volo.Abp.AspNetCore.Components.Web.Theming/PageToolbars/SimplePageToolbarContributor.cs
Show resolved
Hide resolved
.../src/Volo.Abp.AspNetCore.Components.Web.Theming/PageToolbars/SimplePageToolbarContributor.cs
Show resolved
Hide resolved
EngincanV
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimplePageToolbarContributorwill be recreated when the page refreshes. We can cache the permission check result.Resolve #24608