Fix project file filtering and solution command execution#24697
Merged
Fix project file filtering and solution command execution#24697
Conversation
1 task
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes two issues in the ABP CLI: incorrect project file filtering logic and missing working directory parameters for dotnet solution commands.
Changes:
- Fixed bin/obj directory filtering in
DerivedClassFinderto useFullNamewith proper path comparison instead ofDirectoryName - Added
workingDirectoryparameter todotnet slncommands inRemoveProjectFromSolutionFileAsyncmethod - Added performance optimization in
IsDerivedmethod to skip parsing files without class declarations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| SolutionFileModifier.cs | Adds working directory parameter to dotnet sln list/remove commands and removes trailing whitespace |
| DerivedClassFinder.cs | Fixes bin/obj folder exclusion logic using FullName and adds early exit optimization for files without classes |
framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/SolutionFileModifier.cs
Outdated
Show resolved
Hide resolved
…on/SolutionFileModifier.cs Co-authored-by: Copilot <[email protected]>
2 tasks
yekalkan
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #24676