Use EntityCacheItemWrapper in cache config#24772
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes entity cache option configuration so the options set via AddEntityCache(...) are applied to the actual distributed cache used by entity caching (EntityCacheItemWrapper<T>), addressing #24770.
Changes:
- Configure
AbpDistributedCacheOptionsusingEntityCacheItemWrapper<T>in allAddEntityCacheoverloads. - Update the TestApp module to register entity caches with explicit
DistributedCacheEntryOptions. - Add tests asserting the configured cache entry options are applied for entity cache distributed caches.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| framework/src/Volo.Abp.Ddd.Domain/Volo/Abp/Domain/Entities/Caching/EntityCacheServiceCollectionExtensions.cs | Switches cache option configuration to target EntityCacheItemWrapper<T> so entity cache options are actually applied. |
| framework/test/Volo.Abp.TestApp/Volo/Abp/TestApp/TestAppModule.cs | Registers entity caches with explicit expiration options to validate configuration behavior. |
| framework/test/Volo.Abp.TestApp/Volo/Abp/TestApp/Testing/EntityCache_Tests.cs | Adds tests verifying the configured default entry options are applied (via reflection on DistributedCache). |
...lo.Abp.Ddd.Domain/Volo/Abp/Domain/Entities/Caching/EntityCacheServiceCollectionExtensions.cs
Show resolved
Hide resolved
framework/test/Volo.Abp.TestApp/Volo/Abp/TestApp/Testing/EntityCache_Tests.cs
Outdated
Show resolved
Hide resolved
framework/test/Volo.Abp.TestApp/Volo/Abp/TestApp/Testing/EntityCache_Tests.cs
Outdated
Show resolved
Hide resolved
framework/test/Volo.Abp.TestApp/Volo/Abp/TestApp/Testing/EntityCache_Tests.cs
Show resolved
Hide resolved
...lo.Abp.Ddd.Domain/Volo/Abp/Domain/Entities/Caching/EntityCacheServiceCollectionExtensions.cs
Show resolved
Hide resolved
...lo.Abp.Ddd.Domain/Volo/Abp/Domain/Entities/Caching/EntityCacheServiceCollectionExtensions.cs
Show resolved
Hide resolved
EngincanV
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #24770