Refactor forms in various management pages to include specific form IDs for better handling of submissions#24816
Merged
yagmurcelk merged 2 commits intorel-10.0from Feb 6, 2026
Merged
Conversation
…Ds for better handling of submissions
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds explicit form IDs to modal forms in various management pages and associates SubmitButtons with their respective forms using the Form attribute. This improves form handling by explicitly linking submit buttons to their target forms, which is particularly useful when multiple forms exist on a page or when buttons are outside the form element structure.
Changes:
- Added unique IDs to Create and Edit modal forms in Tenant Management, User Management, and Role Management pages
- Updated corresponding SubmitButton components to reference their forms via the
Formattribute - Partially updated the Send Test Email modal in Email Settings (form ID added but button not updated)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| modules/tenant-management/src/Volo.Abp.TenantManagement.Blazor/Pages/TenantManagement/TenantManagement.razor | Added id attributes to CreateTenantForm and EditTenantForm, and updated SubmitButtons to reference these forms |
| modules/setting-management/src/Volo.Abp.SettingManagement.Blazor/Pages/SettingManagement/EmailSettingGroup/EmailSettingGroupViewComponent.razor | Added id attribute to SendTestEmailForm (but button not updated to SubmitButton component) |
| modules/identity/src/Volo.Abp.Identity.Blazor/Pages/Identity/UserManagement.razor | Added id attributes to CreateUserForm and EditUserForm, and updated SubmitButtons to reference these forms |
| modules/identity/src/Volo.Abp.Identity.Blazor/Pages/Identity/RoleManagement.razor | Added id attributes to CreateRoleForm and EditRoleForm, and updated SubmitButtons to reference these forms |
...gement.Blazor/Pages/SettingManagement/EmailSettingGroup/EmailSettingGroupViewComponent.razor
Show resolved
Hide resolved
yagmurcelk
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.