Use static proxy to get ApplicationConfiguration.#24894
Merged
oykuermann merged 2 commits intorel-10.1from Feb 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts DI registration for ABP-generated static client proxies so ApplicationConfiguration (and tenant) services are obtained via the static proxy implementation rather than requiring explicit manual registrations.
Changes:
- Removed explicit
AddTransientregistrations forAbpApplicationConfigurationClientProxyandAbpTenantClientProxyfrom the client common module. - Enabled conventional DI registration for the generated proxy types by removing
[DisableConventionalRegistration]from the proxy partial classes. - Cleaned up now-unused
usingdirectives related to those manual registrations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| framework/src/Volo.Abp.AspNetCore.Mvc.Client.Common/Volo/Abp/AspNetCore/Mvc/Client/AbpAspNetCoreMvcClientCommonModule.cs | Removes manual proxy registrations so DI relies on conventional registration + exposed services from generated proxies. |
| framework/src/Volo.Abp.AspNetCore.Mvc.Client.Common/ClientProxies/AbpTenantClientProxy.cs | Removes conventional-registration opt-out so the generated proxy can be registered/exposed automatically. |
| framework/src/Volo.Abp.AspNetCore.Mvc.Client.Common/ClientProxies/AbpApplicationConfigurationClientProxy.cs | Removes conventional-registration opt-out so the generated proxy can be registered/exposed automatically. |
oykuermann
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.