Reject non-generic collections and add tests#24917
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request resolves issue #24914 by fixing an IndexOutOfRangeException that occurred when attempting to map to non-generic derived collection types (e.g., class CarDtoList : List<CarDto>). The fix adds a guard check to reject non-generic types before attempting to access their generic arguments, and includes comprehensive test coverage for various collection mapping scenarios.
Changes:
- Added guard check in
ObjectMappingHelper.IsCollectionGenericTypeInternalto reject non-generic derived collection types - Added comprehensive unit tests covering standard collections, arrays, interfaces, and the edge case of non-generic derived collections
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| framework/src/Volo.Abp.ObjectMapping/Volo/Abp/ObjectMapping/ObjectMappingHelper.cs | Added guard check to prevent IndexOutOfRangeException when a type implements generic collection interfaces but is not itself generic |
| framework/test/Volo.Abp.ObjectMapping.Tests/Volo/Abp/ObjectMapping/ObjectMappingHelper_Tests.cs | Added comprehensive unit tests covering various collection type scenarios including the edge case that triggered the original bug |
framework/src/Volo.Abp.ObjectMapping/Volo/Abp/ObjectMapping/ObjectMappingHelper.cs
Outdated
Show resolved
Hide resolved
EngincanV
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #24914