Skip to content

Remove redundant "Permissions" heading from resource permission management modals#24977

Merged
yagmurcelk merged 2 commits intorel-10.2from
copilot/remove-resource-permission-header
Mar 2, 2026
Merged

Remove redundant "Permissions" heading from resource permission management modals#24977
yagmurcelk merged 2 commits intorel-10.2from
copilot/remove-resource-permission-header

Conversation

Copy link
Contributor

Copilot AI commented Feb 27, 2026

Description

Resolves https://github.com/volosoft/volo/issues/21742

image image

Removes the unnecessary <h4> heading (localization key: ResourcePermissionPermissions) that appeared above the "grant-all" checkbox/switch in the resource-based authorization modals for MVC and Blazor UIs.

Files changed:

  • AddResourcePermissionManagementModal.cshtml — removed heading
  • UpdateResourcePermissionManagementModal.cshtml — removed heading
  • ResourcePermissionManagementModal.razor — removed heading from both Create and Edit modal sections

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI changed the title [WIP] Remove unnecessary heading from modals in MVC and Blazor Remove redundant "Permissions" heading from resource permission management modals Feb 27, 2026
@EngincanV EngincanV requested a review from maliming February 27, 2026 07:39
@EngincanV EngincanV marked this pull request as ready for review February 27, 2026 07:39
@EngincanV EngincanV added this to the 10.2-final milestone Feb 27, 2026
@EngincanV EngincanV removed the request for review from maliming February 27, 2026 07:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a redundant "Permissions" heading (localization key: ResourcePermissionPermissions) from resource-based permission management modals across both MVC and Blazor UI implementations. The heading appeared immediately above the "grant-all" checkbox/switch and was unnecessary given the modal titles already provide clear context about managing resource permissions.

Changes:

  • Removed redundant <h4> heading from Add and Update resource permission modals in MVC UI
  • Removed redundant <h4> heading from Create and Edit modal sections in Blazor UI

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
UpdateResourcePermissionManagementModal.cshtml Removed redundant "Permissions" heading from update modal
AddResourcePermissionManagementModal.cshtml Removed redundant "Permissions" heading from add modal
ResourcePermissionManagementModal.razor Removed redundant "Permissions" heading from both Create and Edit modal sections

@maliming
Copy link
Member

hi @yagmurcelk

Can you share screenshots of the new create/update UI pages before merging it?

Thanks,.

@EngincanV
Copy link
Member

hi @yagmurcelk

Can you share screenshots of the new create/update UI pages before merging it?

Thanks,.

Added for MVC UI in the PR description.

@yagmurcelk yagmurcelk merged commit 604be2c into rel-10.2 Mar 2, 2026
7 of 8 checks passed
@yagmurcelk yagmurcelk deleted the copilot/remove-resource-permission-header branch March 2, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants