Skip to content

update: enhance resource permission management modal initialization#24985

Merged
EngincanV merged 3 commits intorel-10.1from
modalClass-ResourcePermissionManagement
Mar 2, 2026
Merged

update: enhance resource permission management modal initialization#24985
EngincanV merged 3 commits intorel-10.1from
modalClass-ResourcePermissionManagement

Conversation

@maliming
Copy link
Member

@maliming maliming commented Feb 28, 2026

Resolves #24982

Copilot AI review requested due to automatic review settings February 28, 2026 04:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Permission Management module documentation so the Resource Permission Management modal is initialized correctly in MVC/Razor Pages scenarios (ensuring the modal script class is invoked as intended).

Changes:

  • Updates the abp.ModalManager example to use the object-parameter form.
  • Adds the missing modalClass: 'ResourcePermissionManagement' option to the docs sample.

@abou-emish
Copy link

abou-emish commented Mar 1, 2026

We also need to add the script file to the page, it doesn't work without?

<abp-script src="proxy.php?url=/Pages/AbpPermissionManagement/resource-permission-management-modal.js" />

@maliming
Copy link
Member Author

maliming commented Mar 1, 2026

hi @abou-emish

Yes, you need to add resource-permission-management-modal.js in your page

@section scripts
{
    <abp-script src="proxy.php?url=/Pages/Books/Index.js"/>
    <abp-script src="proxy.php?url=/Pages/AbpPermissionManagement/resource-permission-management-modal.js" />
}

@maliming maliming requested a review from EngincanV March 1, 2026 09:30
@EngincanV EngincanV merged commit fd16004 into rel-10.1 Mar 2, 2026
2 checks passed
@EngincanV EngincanV deleted the modalClass-ResourcePermissionManagement branch March 2, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants