Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a per-request caching bug in MvcCachedApplicationConfigurationClient by ensuring the HttpContext.Items key used to store the distributed-cache key is isolated by user identity, preventing an “anonymous” key computed pre-authentication from being reused after authentication.
Changes:
- Replace the fixed
HttpContext.Itemskey with a formatted key that includes the current user id (orAnonymous). - Apply the new per-user
Itemskey in both async (GetAsync) and sync (Get) code paths.
...NetCore.Mvc.Client/Volo/Abp/AspNetCore/Mvc/Client/MvcCachedApplicationConfigurationClient.cs
Outdated
Show resolved
Hide resolved
...NetCore.Mvc.Client/Volo/Abp/AspNetCore/Mvc/Client/MvcCachedApplicationConfigurationClient.cs
Outdated
Show resolved
Hide resolved
...NetCore.Mvc.Client/Volo/Abp/AspNetCore/Mvc/Client/MvcCachedApplicationConfigurationClient.cs
Outdated
Show resolved
Hide resolved
...NetCore.Mvc.Client/Volo/Abp/AspNetCore/Mvc/Client/MvcCachedApplicationConfigurationClient.cs
Show resolved
Hide resolved
...NetCore.Mvc.Client/Volo/Abp/AspNetCore/Mvc/Client/MvcCachedApplicationConfigurationClient.cs
Show resolved
Hide resolved
...NetCore.Mvc.Client/Volo/Abp/AspNetCore/Mvc/Client/MvcCachedApplicationConfigurationClient.cs
Outdated
Show resolved
Hide resolved
...NetCore.Mvc.Client/Volo/Abp/AspNetCore/Mvc/Client/MvcCachedApplicationConfigurationClient.cs
Outdated
Show resolved
Hide resolved
EngincanV
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
httpContext.Itemscache key forMvcCachedApplicationConfigurationClientApplicationConfigurationDto_CacheKey) was used to cache the distributed cache key inhttpContext.Items. If the service was called before authentication middleware, it would cache an anonymous key and reuse it after the user was authenticated, leading to wrong configuration being servedApplicationConfigurationDto_{userId}_{culture}_CacheKeyformat, so different authentication states and cultures naturally use different Items keys and don't interfere with each otherGetHttpContextItemsCacheKeyhelper method to avoid duplication betweenGetAsyncand Get`